Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Удаление доступа у питомца снабжения #1771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mirka-l
Copy link

@Mirka-l Mirka-l commented Jan 29, 2025

Удаление доступа у питомца отдела снабжения

Что этот PR делает

Удаляет доступ у гориллы отдела снабжения

Почему это хорошо для игры

Число незаметных проникновений в отдел снабжения снизится

Изображения изменений

Тестирование

Протестировал на локальном билде толкая гориллу в шлюзы отдела снабжения, шлюзы как и ожидалось не открываются

Changelog

🆑
tweak: Отобран доступ у гориллы отдела снабжения
/:cl:

Summary by Sourcery

Tests:

  • Tested locally by pushing the gorilla into the supply airlocks.

Удаление доступа у питомца отдела снабжения
Copy link

sourcery-ai bot commented Jan 29, 2025

Reviewer's Guide by Sourcery

This pull request removes the supply access from the cargo gorilla. This change prevents the gorilla from opening supply doors.

Sequence diagram showing cargo gorilla interaction with supply doors

sequenceDiagram
    participant Gorilla
    participant Door as Supply Door
    participant ID as Cargo Gorilla ID
    Gorilla->>Door: Attempt to open
    Door->>ID: Check access
    ID-->>Door: No access
    Door-->>Gorilla: Access denied
Loading

File-Level Changes

Change Details Files
Removed supply access from the cargo gorilla.
  • Created a new file for the cargo gorilla's access.
  • Removed all access from the cargo gorilla.
modular_ss220/mobs/code/simple_animal/hostile/gorilla.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 29, 2025
@m-dzianishchyts
Copy link
Collaborator

Оказывается, у гориллы есть геймплей для госта и это изменение его ломает. Увы, решение только через КЗ

@AyIong
Copy link
Collaborator

AyIong commented Jan 29, 2025

Я перепутал с ТГ

@AyIong AyIong reopened this Jan 29, 2025
@@ -0,0 +1,2 @@
/obj/item/card/id/supply/cargo_gorilla
access = list()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я верен что список не так опустошается. Вроде через .Cut

Copy link
Collaborator

@m-dzianishchyts m-dzianishchyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все еще ждем восстановление доступа, когда гориллой управляет игрок

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 CL валиден Этот чейнджлог будет успешно опубликован
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants