Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM] Пустые куклы #1805

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

msw7007
Copy link

@msw7007 msw7007 commented Feb 14, 2025

Что этот PR делает

Сделено по запросу старшего администратора.
Создает расу для щитспавна. Особености расы - големы (заблокированы все слоты кроме ушей, карты, рук, карманов и ПДА), с возможностью подгрузки иконок. Имеет все особенности человеческого строения. Иконки не обновляются при реджуве, позволяя подгружать в раунды иконки других билдов гуманоидов/монстров без особых сложностей.
Метод подгрузки - создать куклу, заменить icon через VV на иконку, icon_state на название иконки существа.
В случае необходимости флаги блокировок можно снять.

Почему это хорошо для игры

Дает больше простора администраторам для щитспавна кастомных гуманоидных рас.

Изображения изменений

Тестирование

На локальном сервере

NPFFC

Summary by Sourcery

New Features:

  • Add a new "Doll" species for admins to use for shieldspawn. It has all the features of a human but with all item slots except ears, hand, pockets, and PDA blocked. The icons can be customized by changing the icon and icon_state VV variables, and they do not update on rejuvenate, allowing for custom icons per round without difficulty. The blocking flags can be removed if needed.

Copy link

sourcery-ai bot commented Feb 14, 2025

Reviewer's Guide by Sourcery

This pull request introduces a new 'Doll' species designed for administrators to spawn custom humanoid races. The species is based on a golem-like structure with limited equipment slots and allows for dynamic icon loading, enabling the creation of diverse humanoid/monster appearances. The implementation involves creating a new species datum, defining custom body parts, and setting up the mob.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new 'Doll' species.
  • Created a new species datum 'human_doll'.
  • Defined the species name and plural name.
  • Set the species' icobase and eyes_icon to a placeholder.
  • Restricted equipment slots to ears, card, hands, pockets, and PDA.
  • Defined the species' limbs and their corresponding paths.
modular_ss220/species/eventdoll/code/ed_spieces.dm
Implemented custom body parts for the 'Doll' species.
  • Created new organ items for each body part (head, chest, groin, arms, legs, hands, feet).
  • Set the icon_name and icobase for each body part to a placeholder.
  • Implemented a New() proc for each body part to update the icon alt.
  • Added a update_icon_alt proc to update the DNA and sync the colour to the human.
  • Added a surgery component to each body part.
modular_ss220/species/eventdoll/code/ed_bodyparts.dm
Added a dummy change_icobase proc for the 'Doll' species.
  • Added a dummy change_icobase proc to the human_doll mob.
  • The proc does nothing.
modular_ss220/species/eventdoll/code/ed_reprocs.dm
Added a new 'human_doll' mob type.
  • Created a new mob type 'human_doll' that inherits from human.
  • Initialized the mob with the 'human_doll' species.
modular_ss220/species/nucleations/code/mob/living/carbon/human/human_mob.dm
Added new files to the project.
  • Added '_eventdoll.dme' to the project.
  • Added 'eventdoll/code/ed_bodyparts.dm' to the project.
  • Added 'eventdoll/code/ed_spieces.dm' to the project.
  • Added 'eventdoll/code/ed_reprocs.dm' to the project.
modular_ss220/species/_species.dme

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! label Feb 14, 2025
@ss220app ss220app bot added the 📜 CL невалиден Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется label Feb 14, 2025
@m-dzianishchyts
Copy link
Collaborator

Да, плейсхолдер надо бы сделать видимым. Обычный хуман вполне подойдет

@m-dzianishchyts m-dzianishchyts added the 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать label Feb 14, 2025
@ss220app ss220app bot removed the 📜 CL невалиден Этот чейнджлог не пройдет валидацию перед публикацией. Исправить или удалить, если не требуется label Feb 14, 2025
@github-actions github-actions bot added the :feelsgood: Частичная модульность Не всегда получается всё впихнуть в модуль, увы. label Feb 16, 2025
@m-dzianishchyts m-dzianishchyts changed the title Пустые куклы [TM] Пустые куклы Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:feelsgood: Частичная модульность Не всегда получается всё впихнуть в модуль, увы. 🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! 📜 CL не требуется Эти изменения не влияют на игровой процесс или игроки по какой-то причине не должны о них знать Testmerge Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants