Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: event emitter will now emit new_txid in-case a tx replaces another #5381

Closed
wants to merge 10 commits into from
Closed

feat: event emitter will now emit new_txid in-case a tx replaces another #5381

wants to merge 10 commits into from

Conversation

usagi32
Copy link

@usagi32 usagi32 commented Oct 24, 2024

This extra information is required by an issue in the blockchain-api here and here.

Event emitter will now give to the api node which transaction replaced another.

@usagi32 usagi32 requested a review from a team as a code owner October 24, 2024 19:24
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@usagi32 usagi32 mentioned this pull request Oct 24, 2024
Open
jferrant
jferrant previously approved these changes Oct 24, 2024
View reviewed changes
@jferrant jferrant self-requested a review October 24, 2024 19:44
@jferrant
Copy link
Collaborator

I could be wrong, but I think this may need to be opened against develop, not master.

@usagi32
Copy link
Author

usagi32 commented Oct 24, 2024

@jferrant yes didn't know it existed.

@usagi32 usagi32 changed the base branch from master to develop October 24, 2024 19:58
@usagi32 usagi32 dismissed jferrant’s stale review October 24, 2024 19:58

The base branch was changed.

jcnelson
jcnelson previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, pending CI passes. Thanks @usagi32!

@hstove
Copy link
Contributor

hstove commented Nov 8, 2024

@usagi32 you'll have to fix some of the formatting errors before CI runs tests - you can see these by running cargo fmt-stacks

obycode
obycode previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jcnelson
jcnelson previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @usagi32!

hstove
hstove previously approved these changes Nov 21, 2024
View reviewed changes
@hstove
Copy link
Contributor

hstove commented Nov 21, 2024

Ah, unfortunately there's a new compilation error, assuming from after merging in develop.

@jbencin jbencin dismissed stale reviews from hstove, jcnelson, and obycode via 91f2a32 November 25, 2024 14:53
@jbencin
Copy link
Contributor

jbencin commented Nov 25, 2024

Fixed build errors and merged latest develop

@hstove hstove self-requested a review November 25, 2024 16:07
obycode
obycode approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

obycode
obycode previously requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a changelog entry for this?

@hstove hstove dismissed obycode’s stale review December 18, 2024 19:56

Changelog updated

@hstove hstove requested a review from obycode December 18, 2024 19:56
@hstove hstove requested a review from a team as a code owner December 18, 2024 20:02
@hstove hstove self-requested a review December 18, 2024 20:02
hstove
hstove previously approved these changes Dec 18, 2024
View reviewed changes
obycode
obycode reviewed Dec 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@hstove hstove self-requested a review December 19, 2024 15:44
@hstove hstove added this to the 3.1.0.0.3 milestone Dec 19, 2024
@hstove hstove requested a review from obycode December 19, 2024 18:43
obycode
obycode previously approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obycode
Copy link
Contributor

obycode commented Dec 20, 2024

Oh, it's not running the CI jobs because the last commit only changed a markdown file. Looks like we need some adjustments to the CI rules.

@hstove
Copy link
Contributor

hstove commented Dec 20, 2024

@obycode I think it's something to do with me pushing to this forked branch, I'm not sure. Maybe I'll need to open a new PR...

@hstove hstove mentioned this pull request Dec 20, 2024
Merged
@obycode
Copy link
Contributor

obycode commented Dec 20, 2024

Looks like merging develop was enough to get it to trigger, so maybe my Markdown theory was correct?

@hstove
Copy link
Contributor

hstove commented Dec 20, 2024 •
edited
Loading

Closing, reoponed as #5605

@hstove hstove closed this Dec 20, 2024
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obycode obycode obycode approved these changes

@jferrant jferrant Awaiting requested review from jferrant

@jcnelson jcnelson Awaiting requested review from jcnelson

@hstove hstove Awaiting requested review from hstove

Assignees

@hstove hstove

Labels
locked
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
3.1.0.0.4
Development

Successfully merging this pull request may close these issues.
8 participants
@usagi32 @CLAassistant @jferrant @hstove @jbencin @obycode @blockstack-devops @jcnelson