feat: event emitter will now emit new_txid in-case a tx replaces another #5605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obycode
approved these changes
Dec 20, 2024
zone117x
approved these changes
Dec 20, 2024
auto-merge was automatically disabled
December 20, 2024 17:14
Pull Request is not mergeable
auto-merge was automatically disabled
December 20, 2024 17:15
Pull Request is not mergeable
auto-merge was automatically disabled
December 20, 2024 17:19
Pull Request is not mergeable
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same code as in #5381 , but pushing to this repo directly to try and get CI to run.
This extra information is required by an issue in the blockchain-api here and here.
Event emitter will now give to the api node which transaction replaced another.