Fix standalone build and resolve cran check notes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is excellent! Ill try to review it first thing tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Mans! I'm currently getting all of the Stan R packages building on our r-universe page, and
posteriordb-ris failing checks because there is noPDB_PATHset, as well as a handful of other minor notesThis PR updates the vignettes and tests to check for a defined PDB path, and clone the repo into a tempdir if not found. I've also addressed several other minor notes from the CRAN checks (package not in title case, S3 methods not exported, and outdated links)