feat: decouple from snjs #194

avimak · 2023-10-02T15:40:54Z

Implemented JSON-RPC SNIP (https://community.starknet.io/t/snip-standardizing-starknet-wallet-connections-with-write-api-and-json-rpc-integration/98049)
Decoupled get-starknet-core from snjs
Added silent mode to wallet-window connection

1. Implemented JSON-RPC SNIP (https://community.starknet.io/t/snip-standardizing-starknet-wallet-connections-with-write-api-and-json-rpc-integration/98049) 2. Decoupled get-starknet-core from snjs 3. Added silent mode to wallet-window connection

it will be complicated for wallets to decode FELT-encoded entrypoints. it's doable but slow, and slightly shifting from a pure RPC-schema approach seems reasonable in this use case.

packages/core/src/StarknetWindowObject.ts

fracek · 2023-10-18T13:33:03Z

I can't comment inline because there was no change, but in my experience icon should be icon: { dark: string; light: string } to support dark mode or half of the developers will ignore it.

packages/core/src/StarknetWindowObject.ts

dhruvkelawala · 2023-12-04T07:34:25Z

packages/ui/src/main.ts

@@ -39,11 +40,14 @@ export interface ConnectOptions extends GetWalletOptions {
  storeVersion?: StoreVersion
 }

-const enableWithVersion = async (wallet: StarknetWindowObject | null) => {
+const enableWithVersion = async (


Should get rid of this method and just use connect -> sn.enable()

could u pls show with code? 🙏

dhruvkelawala · 2023-12-04T07:51:38Z

I can't comment inline because there was no change, but in my experience icon should be icon: { dark: string; light: string } to support dark mode or half of the developers will ignore it.

Maybe we can do a complex typing here like

interface IconOptions {
dark: "darkIcon",
light: "lightIcon",
}

interface IStarknetWindoObject {
// Other properties...

icon: IconOptions | string

}

If it's only a string, we apply the same icon for both dark and light mode in the Wallet connection modal.

packages/core/src/StarknetWindowObject.ts

dhruvkelawala · 2023-12-11T11:17:42Z

@avimak I think we can also get rid of baseUrl. Sequencer has been deprecated and we should only use rpcUrls now. (https://github.com/ethereum/EIPs/blob/master/EIPS/eip-3085.md#wallet_addethereumchain)

get-starknet/packages/core/src/StarknetWindowObject.ts

Line 190 in d152cce

baseUrl: string

EDIT: we can also get rid of id

…nnected`

packages/core/src/StarknetWindowObject.ts

Co-authored-by: naorye2 <[email protected]>

@amanusk

as-per @amanusk suggestion

packages/core/src/StarknetWindowObject.ts

PhilippeR26 · 2023-12-22T11:00:00Z

packages/core/src/StarknetWindowObject.ts

-} from "starknet4"
+export enum StarknetChainId {
+  SN_MAIN = "0x534e5f4d41494e",
+  SN_GOERLI = "0x534e5f474f45524c49",


You should add Sepolia Testnet, as Braavos is handling it.

SN_SEPOLIA = "0x534e5f5345504f4c4941"

PhilippeR26 · 2023-12-31T15:23:53Z

packages/core/src/StarknetWindowObject.ts

+    /**
+     * The class ABI, as supplied by the user declaring the class
+     */
+    abi?: string


Type string for abi is not working properly.
Only any[] is working properly.

PhilippeR26 · 2024-01-01T18:59:30Z

packages/core/src/StarknetWindowObject.ts


-export type AccountChangeEventHandler = (accounts: string[]) => void
+type Call = {


Call type : This type name already exists in Starknet.js, but their definition are not the same, generating confusion when coding. My proposal is to rename in the interface Call to CallParameters.

PhilippeR26 · 2024-01-03T14:29:24Z

packages/core/src/main.ts


-export interface GetStarknetOptions {
-  windowObject: Record<string, any>
-  isWalletObject: (wallet: any) => boolean


For devs who would like to create their own UI, it will be useful to export for them :

isWalletObject

scanObjectForWallets

* feat: enhance RpcMessage and EventListener types * chore: export more types

…into feat/new-json-rpc-api

avimak added 3 commits October 2, 2023 18:39

feat: decouple from snjs

0a25753

1. Implemented JSON-RPC SNIP (https://community.starknet.io/t/snip-standardizing-starknet-wallet-connections-with-write-api-and-json-rpc-integration/98049) 2. Decoupled get-starknet-core from snjs 3. Added silent mode to wallet-window connection

chore: export TypeData

654ee0e

chore: reverting from raw calldata to calls

db5fae3

it will be complicated for wallets to decode FELT-encoded entrypoints. it's doable but slow, and slightly shifting from a pure RPC-schema approach seems reasonable in this use case.

avimak mentioned this pull request Oct 3, 2023

Feature Request: Expose Wallet Lock State & Disconnect Event #192

Open

ivpavici reviewed Oct 3, 2023

View reviewed changes

packages/core/src/StarknetWindowObject.ts Outdated Show resolved Hide resolved

chore: rename StarkNet to Starknet

d152cce

ivpavici mentioned this pull request Oct 5, 2023

feat: "StarkNet" to "Starknet" starknet-io/starknet.js#723

Merged

6 tasks

PhilippeR26 mentioned this pull request Oct 17, 2023

Decoupled Starknet.js - Experimental Braavos wallet 0.0.1 #196

Closed

ivpavici mentioned this pull request Oct 26, 2023

casing: Starknet instead of StarkNet starknet-io/starknet.js#705

Closed

naorye2 reviewed Nov 27, 2023

View reviewed changes

packages/core/src/StarknetWindowObject.ts Outdated Show resolved Hide resolved

dhruvkelawala reviewed Dec 4, 2023

View reviewed changes

packages/core/src/StarknetWindowObject.ts Show resolved Hide resolved

dhruvkelawala reviewed Dec 4, 2023

View reviewed changes

packages/core/src/StarknetWindowObject.ts Outdated Show resolved Hide resolved

avimak added 3 commits December 14, 2023 15:14

chore: removed isPreauthorized, selectedAddress, chainId, `isCo…

d8d479b

…nnected`

chore: removed baseUrl

9c72098

chore: support custom dark/light icons

08850bf

naorye2 reviewed Dec 18, 2023

View reviewed changes

packages/core/src/StarknetWindowObject.ts Outdated Show resolved Hide resolved

naorye2 reviewed Dec 18, 2023

View reviewed changes

packages/core/src/StarknetWindowObject.ts Outdated Show resolved Hide resolved

avimak and others added 5 commits December 19, 2023 22:07

Update packages/core/src/StarknetWindowObject.ts

b7421b3

Co-authored-by: naorye2 <[email protected]>

Update packages/core/src/StarknetWindowObject.ts

e3c4e21

Co-authored-by: naorye2 <[email protected]>

chore: support wallet_deploymentData request

70d28e2

chore: added missing fields

4c24ad3

chore: added supported-specs request message

e6aa45c

as-per @amanusk suggestion

avimak requested review from naorye2, dhruvkelawala and ivpavici December 21, 2023 20:31

stanleyyconsensys reviewed Dec 22, 2023

View reviewed changes

packages/core/src/StarknetWindowObject.ts Show resolved Hide resolved

PhilippeR26 reviewed Dec 22, 2023

View reviewed changes

PhilippeR26 reviewed Dec 31, 2023

View reviewed changes

PhilippeR26 reviewed Jan 1, 2024

View reviewed changes

PhilippeR26 mentioned this pull request Jan 2, 2024

Decoupled Starknet.js - Experimental Braavos wallet 0.0.2 #209

Closed

PhilippeR26 reviewed Jan 3, 2024

View reviewed changes

dhruvkelawala added 2 commits January 23, 2024 22:42

chore: add the export for GetDeploymentDataResult

0d1f43c

feat: enhance RpcMessage and EventListener types (#211)

29e2071

* feat: enhance RpcMessage and EventListener types * chore: export more types

PhilippeR26 mentioned this pull request Feb 6, 2024

Tests of ArgentX & Braavos experimental wallets #212

Closed

dhruvkelawala approved these changes Feb 8, 2024

View reviewed changes

chore: export more types

694a311

dhruvkelawala changed the base branch from master to next February 15, 2024 13:05

dhruvkelawala deleted the branch develop February 15, 2024 13:13

dhruvkelawala closed this Feb 15, 2024

dhruvkelawala reopened this Feb 15, 2024

dhruvkelawala changed the base branch from next to develop February 15, 2024 13:15

dhruvkelawala added 2 commits February 15, 2024 13:20

Merge branch 'develop' of https://github.com/starknet-io/get-starknet …

603072d

…into feat/new-json-rpc-api

chore: add changeset

4a477fd

dhruvkelawala merged commit 4a0c710 into develop Feb 15, 2024
1 check failed

dhruvkelawala deleted the feat/new-json-rpc-api branch February 15, 2024 13:24

PhilippeR26 mentioned this pull request Feb 22, 2024

Test of ArgentX experimental wallet 22/feb/2024 #218

Closed

avimak mentioned this pull request Mar 3, 2024

feat: wallet_deploymentData #205

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: decouple from snjs #194

feat: decouple from snjs #194

avimak commented Oct 2, 2023

fracek commented Oct 18, 2023

dhruvkelawala Dec 4, 2023

avimak Dec 14, 2023

dhruvkelawala commented Dec 4, 2023

dhruvkelawala commented Dec 11, 2023 •

edited

Loading

PhilippeR26 Dec 22, 2023 •

edited

Loading

PhilippeR26 Dec 31, 2023

PhilippeR26 Jan 1, 2024

PhilippeR26 Jan 3, 2024 •

edited

Loading


		export type AccountChangeEventHandler = (accounts: string[]) => void
		type Call = {

feat: decouple from snjs #194

feat: decouple from snjs #194

Conversation

avimak commented Oct 2, 2023

fracek commented Oct 18, 2023

dhruvkelawala Dec 4, 2023

Choose a reason for hiding this comment

avimak Dec 14, 2023

Choose a reason for hiding this comment

dhruvkelawala commented Dec 4, 2023

dhruvkelawala commented Dec 11, 2023 • edited Loading

PhilippeR26 Dec 22, 2023 • edited Loading

Choose a reason for hiding this comment

PhilippeR26 Dec 31, 2023

Choose a reason for hiding this comment

PhilippeR26 Jan 1, 2024

Choose a reason for hiding this comment

PhilippeR26 Jan 3, 2024 • edited Loading

Choose a reason for hiding this comment

dhruvkelawala commented Dec 11, 2023 •

edited

Loading

PhilippeR26 Dec 22, 2023 •

edited

Loading

PhilippeR26 Jan 3, 2024 •

edited

Loading