chore: expose compilation args for the compile sierra to casm util #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 2, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## arni/declare/post_compilation/size_validation #348 +/- ##
=================================================================================
- Coverage 81.56% 81.46% -0.10%
=================================================================================
Files 42 42
Lines 1833 1818 -15
Branches 1833 1818 -15
=================================================================================
- Hits 1495 1481 -14
Misses 265 265
+ Partials 73 72 -1 ☔ View full report in Codecov by Sentry. |
ArniStarkware
force-pushed
the
arni/declare/compilation/compilation_file
branch
from
8169305
to
4733c8e
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
3e9c6fe
to
4053ee7
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/compilation_file
branch
from
4733c8e
to
2546a4b
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
4053ee7
to
34edd3c
Compare
This was referenced Jul 3, 2024
ArniStarkware
force-pushed
the
arni/declare/compilation/compilation_file
branch
from
2546a4b
to
6a332d4
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
34edd3c
to
959f42e
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/compilation_file
branch
from
6a332d4
to
0f229c0
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
959f42e
to
8224c25
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/compilation_file
branch
from
0f229c0
to
93e2b1b
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
2 times, most recently
from
23ee4bd
to
59b2d0b
Compare
ArniStarkware
changed the base branch from
arni/declare/compilation/compilation_file
to
main
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
4 times, most recently
from
bb34d13
to
7771a0d
Compare
ArniStarkware
changed the base branch from
main
to
arni/declare/post_compilation/size_validation
This was referenced Jul 15, 2024
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
7771a0d
to
bd21d61
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
caf5d12
to
2f6a155
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
10697c5
to
825012e
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
2f6a155
to
13c0bc6
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
825012e
to
14ff21e
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
13c0bc6
to
eec30dd
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
14ff21e
to
1973ad9
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
eec30dd
to
35d7910
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
1973ad9
to
8f817da
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
35d7910
to
4fe8181
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
8f817da
to
77d31d9
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
4fe8181
to
a033681
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
77d31d9
to
b34b37f
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
a033681
to
0e7c3fa
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
b34b37f
to
9a5fb02
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
0e7c3fa
to
857cad9
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
9a5fb02
to
3ad7790
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
857cad9
to
5ab9f5e
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
3ad7790
to
2a2be69
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
5ab9f5e
to
c36865c
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
2a2be69
to
05697a3
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
c36865c
to
a59234b
Compare
yair-starkware
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Reviewed 2 of 3 files at r2, 1 of 1 files at r3.
Reviewable status: 1 of 8 files reviewed, all discussions resolved (waiting on @dafnamatsry and @Yael-Starkware)
ArniStarkware
force-pushed
the
arni/declare/post_compilation/size_validation
branch
from
05697a3
to
446586c
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/expose_compilation_args
branch
from
a59234b
to
fbf2748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is