-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add the gateway compiler to appstate #391
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
==========================================
+ Coverage 83.18% 83.21% +0.03%
==========================================
Files 37 37
Lines 1748 1752 +4
Branches 1748 1752 +4
==========================================
+ Hits 1454 1458 +4
Misses 215 215
Partials 79 79 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry and @Yael-Starkware)
9622e9a
to
0f5d3d2
Compare
132a963
to
4590db3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry and @Yael-Starkware)
0f5d3d2
to
cebb807
Compare
4590db3
to
e5c5da7
Compare
cebb807
to
e2a1f5e
Compare
e5c5da7
to
f44908d
Compare
e2a1f5e
to
152b7ca
Compare
f44908d
to
6e110c6
Compare
152b7ca
to
fdf9ddd
Compare
6e110c6
to
2474874
Compare
4cbcaea
to
acc2304
Compare
f14e790
to
d4ee11d
Compare
acc2304
to
bfbbcc2
Compare
d4ee11d
to
9152413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArniStarkware and @Yael-Starkware)
crates/gateway/src/gateway.rs
line 57 at r4 (raw file):
}), state_reader_factory, gateway_compiler: GatewayCompiler { config: config.compiler_config.clone() },
Please accept the compiler as an argument to new
.
(as discussed before, we also want to do this for the stateless/stateful validators).
Code quote:
gateway_compiler: GatewayCompiler { config: config.compiler_config.clone() },
crates/gateway/src/gateway_test.rs
line 117 at r4 (raw file):
let optional_class_info = match &external_tx { RPCTransaction::Declare(declare_tx) => Some( GatewayCompiler { config: GatewayCompilerConfig {} }
Use the AppState's compiler.
Code quote:
GatewayCompiler { config: GatewayCompilerConfig {} }
bfbbcc2
to
f454e22
Compare
6265f87
to
e470743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @Yael-Starkware)
crates/gateway/src/gateway.rs
line 57 at r4 (raw file):
Previously, dafnamatsry wrote…
Please accept the compiler as an argument to
new
.
(as discussed before, we also want to do this for the stateless/stateful validators).
Done.
crates/gateway/src/gateway_test.rs
line 117 at r4 (raw file):
Previously, dafnamatsry wrote…
Use the AppState's compiler.
Done.
f454e22
to
48314a4
Compare
e470743
to
87825c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
48314a4
to
542d4c3
Compare
87825c1
to
e59df3a
Compare
Merge activity
|
e59df3a
to
33dbd4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
This change is