Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustfmt config to not require nightly #272

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

FreezyLemon
Copy link
Contributor

This PR updates the rustfmt configuration.. by deleting rustfmt.toml.

There are only two or three options that do anything at all. The others are set to their respective default value or otherwise ineffective.

Copied from the commit message:

Options set to their default value:
- wrap_comments
- use_small_heuristics
- fn_single_line

Unnecessary options:
- edition = "2021" (read from Cargo.toml)
- comment_width (wrap_comments = false)

Actual config changes:
- blank_lines_upper_bound: 2 -> 1
- reorder_impl_items: true -> false

This config includes unstable options which make a nightly toolchain necessary to run cargo fmt, which feels unnecessary. As you can see, there is effectively no change to the actual code formatting after this configuration change.

Options set to their default value:
- wrap_comments
- use_small_heuristics
- fn_single_line

Unnecessary options:
- edition = "2021" (read from Cargo.toml)
- comment_width (wrap_comments = false)

Actual config changes:
- blank_lines_upper_bound: 2 -> 1
- reorder_impl_items: true -> false
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.91%. Comparing base (f7f2960) to head (9aebb9a).
Report is 38 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          53       53           
  Lines       12269    12269           
=======================================
  Hits        11523    11523           
  Misses        746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YeungOnion
Copy link
Contributor

Thanks!

@YeungOnion YeungOnion merged commit 7285bde into statrs-dev:master Sep 5, 2024
8 checks passed
@FreezyLemon FreezyLemon deleted the update-rustfmt-config branch September 5, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants