Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustfmt config to not require nightly #272

Merged
merged 4 commits into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install Rust nightly with rustfmt
uses: dtolnay/rust-toolchain@nightly
- name: Install Rust stable with rustfmt
uses: dtolnay/rust-toolchain@stable
with:
components: rustfmt

Expand Down
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,13 @@ git checkout -b <feature_branch> master

Write your code and docs, then ensure it is formatted:

The below sample modify in-place, use `--check` flag to view diff without making file changes.
Not using `fmt` from +nightly may result in some warnings and different formatting.
Our CI will `fmt`, but less chores in commit history are appreciated.

```
cargo +nightly fmt
cargo fmt
```

Add `--check` to view the diff without making file changes.
Our CI will `fmt`, but less chores in commit history are appreciated.

After commiting your code:

```
Expand Down
29 changes: 0 additions & 29 deletions rustfmt.toml

This file was deleted.

1 change: 0 additions & 1 deletion src/distribution/categorical.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ use std::f64;
/// # Examples
///
/// ```
///
/// use statrs::distribution::{Categorical, Discrete};
/// use statrs::statistics::Distribution;
/// use statrs::prec;
Expand Down