Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 5901 #5954

Closed
wants to merge 5 commits into from
Closed

Fix issue 5901 #5954

wants to merge 5 commits into from

Conversation

akash8843
Copy link

@akash8843 akash8843 commented Mar 10, 2025

fix: Update README and benchmark.js comments for accuracy (#5895)

Description

What is the purpose of this pull request?

This PR addresses issue #5895 by correcting comments and documentation:

: README.md: Fixed inaccurate descriptions and clarified function usage examples.

: benchmark.js: Updated comments to better explain benchmark logic and align with fixed calculations.

Related Issues

Does this pull request have any related issues?

This pull request:
Resolves #5895

Acknowledgment

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?
This may include screenshots, references, and/or implementation notes.

No.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 10, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 10, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/binet $\color{green}250/250$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}250/250$
$\color{green}+100.00\%$
stats/base/dists/levy/variance $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$
stats/base/dists/normal/mgf $\color{green}293/293$
$\color{green}+100.00\%$
$\color{green}19/19$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}293/293$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@akash8843
Copy link
Author

akash8843 commented Mar 10, 2025

Subject: Request for Review: Pull Request for Issue #5895

Hello @stdlib/reviewers,

I hope you are doing well!

I have submitted a pull request to resolve Issue #5895 (Refactor README and benchmark.js comment for accuracy ). I have refactored the random number generation logic to use the random/base/uniform module, ensuring better code clarity and alignment with the existing standards in the stdlib package.

I kindly request you to review my PR when you get a chance. Please let me know if there are any improvements or changes needed — I’ll be happy to make adjustments!

Thank you very much for your guidance and support.

Best regards,
Akash Shukla

@0PrashantYadav0
Copy link
Contributor

/stdlib merge

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Mar 11, 2025
@akash8843
Copy link
Author

/stdlib merge

Hey @PrashantYadav0, thanks for checking out my PR!
Let me know if any changes are needed or if I should do anything to get this merged.
Really appreciate your help! 😊

@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@kgryte kgryte removed Potential Duplicate There might be another pull request resolving the same issue. Needs Review A pull request which needs code review. labels Mar 17, 2025
@kgryte
Copy link
Member

kgryte commented Mar 17, 2025

@akash8843 Thank you for your interest in stdlib; however, this PR includes many undesired changes and the referenced issue was already addressed in #5953. As such, I am going to close this PR.

@kgryte kgryte closed this Mar 17, 2025
@kgryte kgryte added the Invalid Invalid question, issue, or pull request. label Mar 17, 2025
@kgryte kgryte mentioned this pull request Mar 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit aec0e88)
5 participants