-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 5901 #5954
Fix issue 5901 #5954
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
Subject: Request for Review: Pull Request for Issue #5895 Hello @stdlib/reviewers, I hope you are doing well! I have submitted a pull request to resolve Issue #5895 (Refactor README and benchmark.js comment for accuracy ). I have refactored the random number generation logic to use the random/base/uniform module, ensuring better code clarity and alignment with the existing standards in the stdlib package. I kindly request you to review my PR when you get a chance. Please let me know if there are any improvements or changes needed — I’ll be happy to make adjustments! Thank you very much for your guidance and support. Best regards, |
/stdlib merge |
Signed-off-by: Akash shukla <[email protected]>
Hey @PrashantYadav0, thanks for checking out my PR! |
@akash8843 Thank you for your interest in stdlib; however, this PR includes many undesired changes and the referenced issue was already addressed in #5953. As such, I am going to close this PR. |
fix: Update README and benchmark.js comments for accuracy (#5895)
Description
What is the purpose of this pull request?
This PR addresses issue #5895 by correcting comments and documentation:
: README.md: Fixed inaccurate descriptions and clarified function usage examples.
: benchmark.js: Updated comments to better explain benchmark logic and align with fixed calculations.
Related Issues
Does this pull request have any related issues?
This pull request:
Resolves #5895
Acknowledgment
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request?
This may include screenshots, references, and/or implementation notes.
No.
@stdlib-js/reviewers