Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testnet and soroban-dev to v20.0.0rc1/2 #494

Merged
merged 10 commits into from
Sep 19, 2023
Merged

Update testnet and soroban-dev to v20.0.0rc1/2 #494

merged 10 commits into from
Sep 19, 2023

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Sep 19, 2023 •
edited by leighmcculloch
Loading

No description provided.

tsachiherman
tsachiherman reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest needs to align with pubnet ( i.e. including the binaries ), so I don't think that we could do that. The build-testing changes looks good.

@leighmcculloch
Copy link
Member

@sreuland Fyi there's some conflicts because #486 already added support for captive core to testnet.

@tsachiherman tsachiherman marked this pull request as ready for review September 19, 2023 21:23
leighmcculloch
leighmcculloch reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear to me why we're making some of the changes we are in this PR. Questions inline.

.github/workflows/build-latest.yml Outdated Show resolved Hide resolved
.github/workflows/build-latest.yml Outdated Show resolved Hide resolved
.github/workflows/build-testing.yml Outdated Show resolved Hide resolved
.github/workflows/build-testing.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
start Outdated Show resolved Hide resolved
testnet/horizon/etc/stellar-captive-core.cfg Outdated Show resolved Hide resolved
testnet/horizon/etc/stellar-captive-core.cfg Show resolved Hide resolved
@leighmcculloch leighmcculloch changed the title update soroban support to be available on testnet Update testnet and soroban-dev to v20.0.0rc1/2 Sep 19, 2023
@leighmcculloch
Copy link
Member

I pushed a series of changes. cc @tsachiherman @sreuland

@leighmcculloch leighmcculloch enabled auto-merge (squash) September 19, 2023 22:22
@leighmcculloch leighmcculloch mentioned this pull request Sep 19, 2023
Merged
@leighmcculloch leighmcculloch merged commit 0ebb6ee into master Sep 19, 2023
76 checks passed
@leighmcculloch leighmcculloch deleted the testnet_soroban_update branch September 19, 2023 23:26
@leighmcculloch leighmcculloch mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsachiherman tsachiherman tsachiherman left review comments

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreuland @leighmcculloch @tsachiherman