Fix port collision between rpc and horizon in testnet config #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason this bug wasn't identified in tests is because CI tests that horizon captive core works, or soroban-rpc works, and it doesn't test both running at the same time. We could enable that. I'll do that in a separate PR to evaluate the time cost because the tests in this repo are a balance between running sufficient tests vs keeping test run time and resources reasonable. |
ire-and-curses
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Set the port of soroban-rpc in the testnet config to 11726.
Why
In #494 we added soroban-rpc to the testnet config, but accidentally assigned its captive stellar-core the same port that the horizon captive stellar-core uses. This causes one of the two to shut down when starting up.
In the local network config we use 11725 for horizon's captive stellar-core, and 11726 for soroban-rpc's captive stellar-core. This change merely follows suit.