Remove the config supporting running horizon without a captive stellar-core #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, horizon's |
I'd rather keep this pull request focused on doing one thing, which is removing the option to control captive. For anyone using captive-core today this change represents a non-functional change, it's 100% refactor and should result in zero side-effects. Changing how captive-core runs would be a functional change and we should keep it separate so that it's easier to tell that the non-functional change is truly non-functional. |
sreuland
approved these changes
Oct 2, 2023
leighmcculloch
deleted the
remove-horizon-that-does-not-use-captive-core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the config supporting running horizon without a captive stellar-core. The only way to run horizon will be with a captive stellar-core.
Why
We have two ways to run horizon, with and without captive core. In the quickstart image the default way is without captive core. Outside of the quickstart image the recommended way is with captive core. As far as I can tell we only support the without captive core way in Horizon for backwards compatibility, but it isn't how we want Horizon to be run.
We should run Horizon in quickstart the way we recommend others to run it, by default.
We should remove the option to choose which way to run Horizon because having two ways to run a thing makes maintaining the image harder.