Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strkey str conversions for ScAddress #315

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add strkey str conversions for ScAddress #315

merged 1 commit into from
Oct 25, 2023

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Oct 24, 2023 •
edited
Loading

What

Add strkey str conversions for ScAddress.

Why

When I added strkey str conversions for others types in #313, I missed ScAddress.

@leighmcculloch leighmcculloch marked this pull request as ready for review October 24, 2023 21:44
@leighmcculloch leighmcculloch added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 16f4d7c Oct 25, 2023
7 checks passed
@leighmcculloch leighmcculloch deleted the enjeopardy-myopathy branch October 25, 2023 01:34
@leighmcculloch leighmcculloch linked an issue Oct 26, 2023 that may be closed by this pull request
Addresses in JSON are rendered as JSON objects containing hex strings but should be strkeys #300
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisuresh sisuresh sisuresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addresses in JSON are rendered as JSON objects containing hex strings but should be strkeys
2 participants
@leighmcculloch @sisuresh