Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in JSON-encoded field for a getLedgerEntries result #1050

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix typo in JSON-encoded field for a getLedgerEntries result #1050

merged 2 commits into from
Oct 25, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Oct 25, 2023

The diff is self-explanatory: this appears to be a typo.

@Shaptic Shaptic added the bug Something isn't working label Oct 25, 2023
tsachiherman
tsachiherman suggested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the corresponding decoder in the rust code..

@tsachiherman
Copy link
Contributor

please fix the corresponding decoder in the rust code..

i.e. soroban-tools/cmd/soroban-cli/src/rpc/mod.rs

@Shaptic
Copy link
Contributor Author

Shaptic commented Oct 25, 2023

@tsachiherman good call, done!

@Shaptic Shaptic requested a review from tsachiherman October 25, 2023 16:52
@Shaptic Shaptic merged commit 1e42daf into main Oct 25, 2023
17 checks passed
@Shaptic Shaptic deleted the json-field-typo branch October 25, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsachiherman tsachiherman tsachiherman approved these changes

@2opremio 2opremio 2opremio approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shaptic @tsachiherman @2opremio