Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in JSON-encoded field for a getLedgerEntries result #1050

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix typo in JSON-encoded field for a getLedgerEntries result #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4629e3
Fix typo in JSON-encoded field for a `getLedgerEntries` result
Shaptic Oct 25, 2023
b27bee6
Fixup the corresponding CLI decoding name as well
Shaptic Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/soroban-cli/src/rpc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ pub struct LedgerEntryResult {
)]
pub last_modified_ledger: u32,
#[serde(
rename = "liveUntilLedgerSeqLedgerSeq",
rename = "liveUntilLedgerSeq",
skip_serializing_if = "Option::is_none",
deserialize_with = "deserialize_option_number_from_string",
default
Expand Down
2 changes: 1 addition & 1 deletion cmd/soroban-rpc/internal/methods/get_ledger_entries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type LedgerEntryResult struct {
// Last modified ledger for this entry.
LastModifiedLedger int64 `json:"lastModifiedLedgerSeq,string"`
// The ledger sequence until the entry is live, available for entries that have associated ttl ledger entries.
LiveUntilLedgerSeq *uint32 `json:"liveUntilLedgerSeqLedgerSeq,string,omitempty"`
LiveUntilLedgerSeq *uint32 `json:"liveUntilLedgerSeq,string,omitempty"`
}

type GetLedgerEntriesResponse struct {
Expand Down