Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load default configuration into env vars. #1716

Merged
merged 2 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions cmd/soroban-cli/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use clap::CommandFactory;
use dotenvy::dotenv;
use tracing_subscriber::{fmt, EnvFilter};

use crate::config::Config;
use crate::print::Print;
use crate::upgrade_check::upgrade_check;
use crate::{commands, Root};
Expand Down Expand Up @@ -33,6 +34,8 @@ pub async fn main() {
}
}

set_env_from_config();

let mut root = Root::new().unwrap_or_else(|e| match e {
commands::Error::Clap(e) => {
let mut cmd = Root::command();
Expand Down Expand Up @@ -86,3 +89,27 @@ pub async fn main() {
std::process::exit(1);
}
}

// Load ~/.config/stellar/config.toml defaults as env vars.
fn set_env_from_config() {
if let Ok(config) = Config::new() {
set_env_value_from_config("STELLAR_ACCOUNT", config.defaults.identity);
set_env_value_from_config("STELLAR_NETWORK", config.defaults.network);
}
}

// Set an env var from a config file if the env var is not already set.
// Additionally, a `$NAME_SOURCE` variant will be set, which allows
// `stellar env` to properly identity the source.
fn set_env_value_from_config(name: &str, value: Option<String>) {
let Some(value) = value else {
return;
};

std::env::remove_var(format!("{name}_SOURCE"));

if std::env::var(name).is_err() {
std::env::set_var(name, value);
std::env::set_var(format!("{name}_SOURCE"), "default");
}
}
23 changes: 10 additions & 13 deletions cmd/soroban-cli/src/commands/env/mod.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
use crate::{
commands::global,
config::{
locator::{self},
Config,
},
config::locator::{self},
print::Print,
};
use clap::Parser;
Expand All @@ -23,14 +20,13 @@ pub enum Error {
impl Cmd {
pub fn run(&self, global_args: &global::Args) -> Result<(), Error> {
let print = Print::new(global_args.quiet);
let config = Config::new()?;
let mut lines: Vec<(String, String)> = Vec::new();

if let Some(data) = get("STELLAR_NETWORK", config.defaults.network) {
if let Some(data) = get("STELLAR_NETWORK") {
lines.push(data);
}

if let Some(data) = get("STELLAR_ACCOUNT", config.defaults.identity) {
if let Some(data) = get("STELLAR_ACCOUNT") {
lines.push(data);
}

Expand All @@ -51,13 +47,14 @@ impl Cmd {
}
}

fn get(env_var: &str, default_value: Option<String>) -> Option<(String, String)> {
if let Ok(value) = std::env::var(env_var) {
return Some((format!("{env_var}={value}"), "env".to_string()));
}
fn get(env_var: &str) -> Option<(String, String)> {
// The _SOURCE env var is set from cmd/soroban-cli/src/cli.rs#set_env_value_from_config
let source = std::env::var(format!("{env_var}_SOURCE"))
.ok()
.unwrap_or("env".to_string());

if let Some(value) = default_value {
return Some((format!("{env_var}={value}"), "default".to_string()));
if let Ok(value) = std::env::var(env_var) {
return Some((format!("{env_var}={value}"), source));
}

None
Expand Down
Loading