Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export signer account instead of signatures #272

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Jul 30, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository. I updated the description of the fuction with the changes that were made.

Release planning

  • I've decided if this PR requires a new major/minor/patch version accordingly to
    semver, and I've changed the name of the BRANCH to release/_ , feature/_ or patch/* .

What

This PR export account of transaction signers instead of signatures themselves

Why

Based on chat with @chowbao in slack it was concluded that for verifying the legitimacy of transactions, accounts of the signers would be more helpful

Known limitations

None

@amishas157 amishas157 marked this pull request as ready for review July 30, 2024 16:44
@amishas157 amishas157 requested a review from a team as a code owner July 30, 2024 16:44
@amishas157 amishas157 merged commit 63b5833 into master Jul 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants