Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return GetTransactionRaw with getTransaction #213

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

willemneal
Copy link
Member

What

getTransaction method should return a GetTransactionResponseRaw which then can be converted to GetTransaction. This was causing the struct to not be deserialized correctly.

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@janewang janewang requested review from 2opremio and Shaptic June 12, 2024 19:58
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good 👍

but why didn't this come up before?

@mollykarcher
Copy link
Contributor

but why didn't this come up before?

Second this. This seems like something that the system-tests should have been able to catch. Did we fail to update the e2e workflow or something?

Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

@leighmcculloch leighmcculloch enabled auto-merge June 13, 2024 00:09
@leighmcculloch leighmcculloch disabled auto-merge June 13, 2024 00:09
@leighmcculloch leighmcculloch enabled auto-merge (squash) June 13, 2024 00:10
@leighmcculloch leighmcculloch disabled auto-merge June 13, 2024 00:10
@leighmcculloch leighmcculloch enabled auto-merge (squash) June 13, 2024 00:10
@leighmcculloch
Copy link
Member

I've approved and am merging this PR. @2opremio @mollykarcher Is there a way to ship this in a bug fix release, such as 21.3.1 instead of waiting for 21.4.0?

@leighmcculloch leighmcculloch merged commit 2570fd2 into stellar:main Jun 13, 2024
21 checks passed
@chadoh chadoh deleted the fix/getTransaction branch June 13, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants