Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return GetTransactionRaw with getTransaction #213

Merged
merged 3 commits into from
Jun 13, 2024
Merged

fix: return GetTransactionRaw with getTransaction #213

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f61d65d
fix: return GetTransactionRaw with getTransaction
willemneal Jun 12, 2024
f4a20fd
keep external interface consistent as GetTransactionResponse
leighmcculloch Jun 12, 2024
aca3976
fmt
leighmcculloch Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/crates/stellar-rpc-client/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,9 @@ impl Client {
pub async fn get_transaction(&self, tx_id: &Hash) -> Result<GetTransactionResponse, Error> {
let mut oparams = ObjectParams::new();
oparams.insert("hash", tx_id)?;
Ok(self.client().request("getTransaction", oparams).await?)
let resp: GetTransactionResponseRaw =
self.client().request("getTransaction", oparams).await?;
Ok(resp.try_into()?)
}

/// Poll the transaction status. Can provide a timeout in seconds, otherwise uses the default timeout.
Expand Down
Loading