Refine logging of migrations and tx ingestion #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downgrade Tx ingestion logging to Debug (otherwise we flood the logs during the migration) Make sure we log whenever a migration is applied
mollykarcher
approved these changes
Jul 4, 2024
|
Integration tests work locally but fail immediately in CI without any logs. My bet is that they are getting killed due to running in parallel. I will address that in a separate PR. |
2opremio
added a commit
to 2opremio/soroban-rpc
that referenced
this pull request
Jul 8, 2024
This reverts commit 556d535.
2opremio
added a commit
to 2opremio/soroban-rpc
that referenced
this pull request
Jul 8, 2024
I didn't adapt the logic right.
This was hard to debug because, in integration tests, it caused the
daemon to run `d.logger.WithError(err).Fatal("could not build
migrations")`, which in turn runs `os.Exit` which ends the test right
away (without flushing logs etc).
I need to think how to improve this. One option is to
override the `ExitFunc` in logrus with an assertion.
Merged
aditya1702
pushed a commit
that referenced
this pull request
Jul 8, 2024
* Fix typo from #237 I didn't adapt the logic right. This was hard to debug because, in integration tests, it caused the daemon to run `d.logger.WithError(err).Fatal("could not build migrations")`, which in turn runs `os.Exit` which ends the test right away (without flushing logs etc). I need to think how to improve this. One option is to override the `ExitFunc` in logrus with an assertion. * Add verbosity again to see what's wrong * Fix the error further * Revert "Add verbosity again to see what's wrong" This reverts commit 0be1cd6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Downgrade Tx ingestion logging to Debug (otherwise we flood the logs during the migration)
Make sure we log whenever a migration is applied
Why
Make logs more intuitive and not excessively verbose
Known limitations
N/A