Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soroban-rpc: Remove publish-dry-run Workflow #63

Merged
merged 12 commits into from
Feb 14, 2024
Merged

Conversation

stellarsaur
Copy link
Contributor

@stellarsaur stellarsaur commented Feb 13, 2024

What

This PR updates the rust.yml workflow file to remove publish-dry-run.

Why

The soroban-tools repo should be responsible for the soroban-test crate, and we aren't releasing the soroban-rpc crate (yet) since it's only used internally by soroban-tools.

@stellarsaur stellarsaur changed the title Publish soroban-rpc Instead of soroban-test in Workflows soroban-rpc: Remove publish-dry-run Workflow Feb 13, 2024
@stellarsaur stellarsaur marked this pull request as ready for review February 13, 2024 21:53
@stellarsaur stellarsaur enabled auto-merge (squash) February 13, 2024 21:54
Copy link
Contributor

@psheth9 psheth9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@stellarsaur stellarsaur merged commit 8d16b4b into main Feb 14, 2024
20 checks passed
@stellarsaur stellarsaur deleted the rpc-publish-dry-run branch February 14, 2024 00:06
psheth9 added a commit that referenced this pull request Feb 21, 2024
Shaptic added a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants