Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate soroban-rpc and publish stellar-rpc-client #93

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

psheth9
Copy link
Contributor

@psheth9 psheth9 commented Mar 2, 2024

What

Rename soroban-rpc to soroban-rpc-crate and also remove outdated soroban-tools refs

Note crate.io is immutable repository so In order to rename we are following these steps:

**New plan:

  • Remove soroban-rpc crate entirely
  • Publish new stellar-rpc-client crate (cloned from soroban-rpc)**

Old plan: This could have introduced breaking change so avoided !!

  • Update readme in soroban-rpc to redirect users to new stellar-rpc-client crate, remove everything else
  • publish soroban-rpc and verify crates.io
  • publish stellar-rpc-client and verify crates.io

Why

See #84 it had created lot of confusion when referring to soroban-rpc client crate as sometimes people percieve it as soroban-rpc service and not client crate. we are just better off with renaming to soroban-rpc-client !!

Known limitations

We might need to update any dependent repositories or downstream components !!

@psheth9 psheth9 self-assigned this Mar 2, 2024
@psheth9 psheth9 marked this pull request as ready for review March 4, 2024 20:34
@Shaptic
Copy link
Contributor

Shaptic commented Mar 5, 2024

I really don't have a strong opinion on this whatsoever but maybe something like rs-rpc-sdk would deliver more information to match things like js-stellar-sdk/java-stellar-sdk/rs-soroban-sdk?

@psheth9
Copy link
Contributor Author

psheth9 commented Mar 5, 2024

@Shaptic Agreed but I think we would be doing that if we actually move out this crate to its own repo. Suggestion from Lei here

cmd/crates/soroban-rpc-client/Cargo.toml Outdated Show resolved Hide resolved
cmd/crates/soroban-rpc-client/README.md Outdated Show resolved Hide resolved
cmd/crates/soroban-rpc-client/Cargo.toml Outdated Show resolved Hide resolved
@psheth9 psheth9 changed the title Rename soroban-rpc to soroban-rpc-client Deprecate soroban-rpc and publish stellar-rpc-client Mar 7, 2024
@psheth9 psheth9 merged commit 57b8f28 into main Mar 13, 2024
21 checks passed
@psheth9 psheth9 deleted the update-soroban-rpc-crate branch March 13, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants