-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate soroban-rpc and publish stellar-rpc-client #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I really don't have a strong opinion on this whatsoever but maybe something like |
psheth9
changed the title
Rename soroban-rpc to soroban-rpc-client
Deprecate soroban-rpc and publish stellar-rpc-client
Mar 7, 2024
leighmcculloch
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rename
soroban-rpc
tosoroban-rpc-crate
and also remove outdatedsoroban-tools
refsNote crate.io is immutable repository so In order to rename we are following these steps:
**New plan:
Old plan: This could have introduced breaking change so avoided !!
soroban-rpc
to redirect users to newstellar-rpc-client
crate, remove everything elseWhy
See #84 it had created lot of confusion when referring to
soroban-rpc
client crate as sometimes people percieve it assoroban-rpc
service and not client crate. we are just better off with renaming tosoroban-rpc-client
!!Known limitations
We might need to update any dependent repositories or downstream components !!