Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate soroban-rpc and publish stellar-rpc-client #93

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Deprecate soroban-rpc and publish stellar-rpc-client #93

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f1279ae
Rename soroban-rpc to soroban-rpc-client
psheth9 Mar 1, 2024
123e3e7
Merge branch 'main' into update-soroban-rpc-crate
psheth9 Mar 2, 2024
caffb24
Merge branch 'main' into update-soroban-rpc-crate
psheth9 Mar 5, 2024
9940365
Keep soroban-rpc with readme and rename soroban-rpc client to stellar…
psheth9 Mar 9, 2024
75a806c
Merge branch 'main' into update-soroban-rpc-crate
psheth9 Mar 9, 2024
efc9820
Add empty lib.rs in order to publish
psheth9 Mar 12, 2024
4413ac0
Fix build-and-test workflow
psheth9 Mar 12, 2024
5b5e4aa
Remove soroban-rpc crate entirely
psheth9 Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

# the soroban CLI & RPC source code to compile and run from system test
# refers to checked out source of current git hub ref context
SYSTEM_TEST_SOROBAN_CLI_REF: https://github.com/stellar/soroban-tools.git\#main
SYSTEM_TEST_SOROBAN_CLI_REF: https://github.com/stellar/soroban-cli.git\#main
SYSTEM_TEST_SOROBAN_RPC_REF: ${{ github.workspace }}/soroban-rpc

# core git ref should be latest commit for stable soroban functionality
Expand Down
12 changes: 6 additions & 6 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[workspace]
resolver = "2"
members = [
"cmd/crates/soroban-rpc",
"cmd/crates/soroban-rpc-client",
"cmd/soroban-rpc/lib/preflight",
]
default-members = ["cmd/crates/soroban-rpc"]
default-members = ["cmd/crates/soroban-rpc-client"]
#exclude = ["cmd/crates/soroban-test/tests/fixtures/hello"]

[workspace.package]
Expand Down Expand Up @@ -37,12 +37,12 @@ version = "=20.3.1"

[workspace.dependencies.soroban-spec-json]
version = "20.3.0"
git = "https://github.com/stellar/soroban-tools"
git = "https://github.com/stellar/soroban-cli"
rev = "a59f5f421a27bab71472041fc619dd8b0d1cf902"

[workspace.dependencies.soroban-spec-typescript]
version = "20.3.0"
git = "https://github.com/stellar/soroban-tools"
git = "https://github.com/stellar/soroban-cli"
rev = "a59f5f421a27bab71472041fc619dd8b0d1cf902"

[workspace.dependencies.soroban-sdk]
Expand All @@ -60,9 +60,9 @@ version = "=20.3.1"
# git = "https://github.com/stellar/rs-soroban-sdk"
# rev = "4aef54ff9295c2fca4c5b9fbd2c92d0ff99f67de"

[workspace.dependencies.soroban-rpc]
[workspace.dependencies.soroban-rpc-client]
version = "20.3.3"
path = "cmd/crates/soroban-rpc"
path = "cmd/crates/soroban-rpc-client"

[workspace.dependencies.stellar-xdr]
version = "=20.1.0"
Expand Down
6 changes: 3 additions & 3 deletions cmd/crates/soroban-rpc/Cargo.toml → cmd/crates/soroban-rpc-client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[package]
name = "soroban-rpc"
name = "soroban-rpc-client"
psheth9 marked this conversation as resolved.
Show resolved Hide resolved
psheth9 marked this conversation as resolved.
Show resolved Hide resolved
description = "Soroban RPC client for rust"
homepage = "https://github.com/stellar/soroban-tools"
repository = "https://github.com/stellar/soroban-tools"
homepage = "https://github.com/stellar/soroban-rpc"
repository = "https://github.com/stellar/soroban-rpc"
authors = ["Stellar Development Foundation <[email protected]>"]
license = "Apache-2.0"
readme = "README.md"
Expand Down
3 changes: 3 additions & 0 deletions cmd/crates/soroban-rpc-client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# soroban-rpc-client

Tools and utilities for soroban rpc client.
psheth9 marked this conversation as resolved.
Show resolved Hide resolved
0 ...oban-rpc/src/fixtures/event_response.json → ...c-client/src/fixtures/event_response.json
View file
Open in desktop
File renamed without changes.
0 cmd/crates/soroban-rpc/src/lib.rs → cmd/crates/soroban-rpc-client/src/lib.rs
View file
Open in desktop
File renamed without changes.
0 cmd/crates/soroban-rpc/src/log.rs → cmd/crates/soroban-rpc-client/src/log.rs
View file
Open in desktop
File renamed without changes.
0 .../soroban-rpc/src/log/diagnostic_events.rs → ...n-rpc-client/src/log/diagnostic_events.rs
View file
Open in desktop
File renamed without changes.
0 cmd/crates/soroban-rpc/src/txn.rs → cmd/crates/soroban-rpc-client/src/txn.rs
View file
Open in desktop
File renamed without changes.
3 changes: 0 additions & 3 deletions cmd/crates/soroban-rpc/README.md
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions cmd/soroban-rpc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ testnet release candidates from the [testing repository.](https://apt.stellar.or
- Follow the build steps listed in [INSTALL.md](https://github.com/stellar/stellar-core/blob/master/INSTALL.md) file for the instructions on building the local binary

## Building Soroban-RPC
- Similar to stellar-core, we will clone the soroban-tools repo and checkout the testnet release tag:
- Similar to stellar-core, we will clone the soroban-rpc repo and checkout the testnet release tag:
```bash
git clone https://github.com/stellar/soroban-tools.git
cd soroban-tools
git clone https://github.com/stellar/soroban-rpc.git
cd soroban-rpc
git fetch --tags
git checkout tags/v20.0.0-rc4 -b soroban-testnet-release
git checkout tags/v20.3.3 -b soroban-testnet-release
```
- Build soroban-rpc target:
```bash
Expand Down
Loading