feat: make unattended for apt, lint of README.md, -u install #773
+156
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passed README.md through markdownlint to clean it up Installation needs an update before running install_prerequisites.sh is now unattended for Dockerfiles
|
Thanks for this. The script update looks great. The readme update I need to be careful with because I had trouble getting it to render correctly both on github.com and stevenlovegrove.github.io/Pangolin where it is also used. When I get a moment I might try splitting this unless you want to do so yourself. |
|
Happy to do :-)
Sent via Superhuman iOS ( ***@***.*** )
…On Sat, Oct 1 2022 at 21:35, Steven Lovegrove < ***@***.*** > wrote:
Thanks for this. The script update looks great. The readme update I need
to be careful with because I had trouble getting it to render correctly
both on github.com and stevenlovegrove.github.io/Pangolin where it is also
used. When I get a moment I might try splitting this unless you want to do
so yourself.
—
Reply to this email directly, view it on GitHub (
#773 (comment)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AANTCRY42VL4PVOJEZQS7ZDWBCG6TANCNFSM5YPTMOWQ
).
You are receiving this because you authored the thread. Message ID: <stevenlovegrove/Pangolin/pull/773/c1264461120
@ github. com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes to make Docker installation of Pangolin work
Cleanup The current README.md now passes markdownlint
Convert install script to be unattended for the apt case so it works with Dockerfile
Updated README.md to note Ubuntu installation needs a -u first