Run testing repo tests against PR #3545
Conversation
mulkieran
force-pushed
the
testing-test
branch
from
ab59741 to
06426fd
Compare
|
Next time, add temporary commit to not run Packit stuff, for that is a waste. |
|
Cockpit tests failed for commit 06426fd. @martinpitt, @jelly, @mvollmer please check. |
Plz ignore. We should be skipping Packit tests anyway...for this PR. |
mulkieran
force-pushed
the
testing-test
branch
2 times, most recently
from
d3fc6b2 to
30b3d6f
Compare
|
@mulkieran FTR, that test failure actually wasn't statis' fault, but an (unrelated) kernel regression. We are currently investigating that. Sorry for the noise on PRs, this is a hard one to debug. What I want to say is: Feel free to run such tests also against cockpit-storage, if it helps you/you want additional coverage. |
mulkieran
force-pushed
the
testing-test
branch
4 times, most recently
from
d293d76 to
a5e6a83
Compare
|
To test stratis-storage/ci#510 |
|
Testing stratis-storage/ci#511 |
mulkieran
force-pushed
the
testing-test
branch
3 times, most recently
from
36b0e6b to
3ff9038
Compare
mulkieran
force-pushed
the
testing-test
branch
3 times, most recently
from
e1bb325 to
9367b37
Compare
|
We are trying to exactly duplicate the behavior of the successful manual test in the auto-test: stratis-storage/testing@35b083c . |
But alas, the test succeeds. |
mulkieran
force-pushed
the
testing-test
branch
2 times, most recently
from
c30709a to
9367b37
Compare
|
I believe the test will fail now... |
mulkieran
force-pushed
the
testing-test
branch
from
41d2421 to
f0a1d25
Compare
|
Likely this will pass, good. |
mulkieran
force-pushed
the
testing-test
branch
6 times, most recently
from
9705aee to
b63d6fe
Compare
mulkieran
force-pushed
the
testing-test
branch
from
b63d6fe to
af3164c
Compare
mulkieran
force-pushed
the
testing-test
branch
from
af3164c to
7651200
Compare
|
This one should realize a single signal failure with adding a cache device |
mulkieran
force-pushed
the
testing-test
branch
from
8eb2648 to
3e445ec
Compare
|
We expect tests to succeed now. |
Specify default integrity journal size in parser as string value. Signed-off-by: mulhern <[email protected]>
Define an enum to represent the tag size. Store the IntegrityTagSpec value in the pool-level metadata. Nothing is gained by turning the enum into bits before storing it in the pool-level metadata. Compute using the bytes value that is at least as large as the number of bits the tag spec represents. Use tag_spec instead of tag_size for the name of the field in the CreatePool method. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Combine both current specs in the struct. The default of both fields is None. Signed-off-by: mulhern <[email protected]>
Use ValidatedIntegritySpec for serialization and to pass to methods invoked by engine's create_pool method. Signed-off-by: mulhern <[email protected]>
This is an option in the D-Bus, the predict script and the pool-level metadata. Signed-off-by: mulhern <[email protected]>
Have the string representation match that for D-Bus API. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
testing-test
branch
from
3e445ec to
710b27d
Compare
No description provided.