-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C/C++/ObjC/ObjC++] Fix javadoc comment word wrap #3855
Conversation
This was broken by e4e5273
a712fd1
to
7127b7b
Compare
I can remember discussions about when leading asterisks are to be treated as punctuation. Especially Mitranim had some objections about it, IIRC. The arguments were about JavaDoc always requiring Go therefore even has an indentation based heuristic to decide when to treat them punctuation. Lines 283 to 288 in 92b4c0b
JavaScript also added this kind of separation in f850f0a. It didn't scope those at all before. At least it not being present in normal block comments is not broken but by intent. I have no objections about it. Actually scope them If we add it here, we should probably also do that for JavaScript. |
This commit adds scoping for leading asterisks in (normal) block comments so ST's word_wrap command can add them to each wrapped line, if present in the first one. Notes: This change aligns JavaScript with Java and C/C++. Related with sublimehq#3855
This commit adds scoping for leading asterisks in (normal) block comments so ST's word_wrap command can add them to each wrapped line, if present in the first one. Notes: This change aligns JavaScript with Java and C/C++. Related with #3855
This commit ... 1. fixes missing closing `punctuation.definition` scopes 2. renames a `.js` final scope to `.json` 3. adjusts leading asterisk scoping according to sublimehq#3855 and sublimehq#3856. 4. refactors comment related contexts to use only named contexts.
This was broken by e4e5273