Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Quick Fix label in hover popup with lightbulb icon #2567

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

jwortmann
Copy link
Member

Currently there is a "Quick Fix" prefix for when code actions are shown in the hover popup.

This is a suggestion to replace that label with the lightbulb icon, because

  • it saves a little bit of space and subjectively looks nicer
  • we filter out non-quickfix actions for the popups, but some servers omit the code action kind and then there might still be actions included which are no quickfixes. I think the lightbulb symbol is more generic and fits better in that case

I used the orange color from Mariana, but I think it should look okay in both dark and light color schemes.

lightbulb

icons/[email protected] Outdated Show resolved Hide resolved
plugin/hover.py Outdated Show resolved Hide resolved
@rchl rchl merged commit 8f505fe into sublimelsp:main Dec 9, 2024
8 checks passed
@jwortmann jwortmann deleted the quickfix-icon branch December 9, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants