Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oauth session #242

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Oauth session #242

wants to merge 44 commits into from

Conversation

avdb13
Copy link
Contributor

@avdb13 avdb13 commented Oct 29, 2024

No description provided.

@avdb13 avdb13 mentioned this pull request Oct 29, 2024
Open
@sugyan
Copy link
Owner

sugyan commented Oct 30, 2024

Thank you for the pull-request!
This is very helpful that you complemented the parts that I had not yet implemented, such as token revoke and refresh, etc..

The Cached part is a faithful port of the CachedGetter from the TypeScript SDK to Rust...? I haven't tried it yet, but it would be a difficult code...
I imagine that we want to prevent the same request from being executed multiple times in parallel like the ThrottledResolver I introduced with atrium-identity. I think it would be nice if we could somehow bundle them in a common form....

@avdb13 avdb13 force-pushed the oauth-session branch 6 times, most recently from b5f94d0 to 1f9f9d8 Compare November 12, 2024 06:33
@avdb13 avdb13 marked this pull request as ready for review November 12, 2024 06:53
@avdb13 avdb13 force-pushed the oauth-session branch 2 times, most recently from 078cb0d to 465c57e Compare November 14, 2024 22:11
@avdb13 avdb13 changed the base branch from main to feature/agent-rework November 14, 2024 22:13
@avdb13 avdb13 changed the base branch from feature/agent-rework to main November 14, 2024 22:13
@avdb13 avdb13 force-pushed the oauth-session branch 7 times, most recently from 8147a40 to 98ff557 Compare November 21, 2024 03:07
@avdb13 avdb13 mentioned this pull request Nov 24, 2024
Draft
@avdb13 avdb13 force-pushed the oauth-session branch 3 times, most recently from 9d73cff to 10d1077 Compare November 24, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avdb13 @sugyan