-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made set_attenuation_coefficients private #243
Conversation
Hey @nabobalis please have a look. |
So this replaces the original pull request? |
This will need a breaking changelog entry as well to round off the PR. |
Co-authored-by: Nabil Freij <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs the changelog tweaking but it LGTM
Looks like one of the examples needs to be updated. |
Co-authored-by: Nabil Freij <[email protected]>
This merge incorporates the latest changes from the remote feature-branch, resolving conflicts in tests/test_radial.py.# Please enter a commit message to explain why this merge is necessary,
Now just the changelog and the precommit left. |
I think it would be easier to run the pre-commit locally and have it fix the issues for you instead of doing it manually. |
Hey @nabobalis i think all the checks have passed please review. |
Hey is this the correct way , apart from moving to utils ?? |
Co-authored-by: Nabil Freij <[email protected]>
Hey @nabobalis i just pressed commit suggestions , now in the latest commit some test got failed , please help me to uncommit the latest commit. |
We don't need to uncommit, we just need to fix it in another commit. |
Thank you very much @Abinash-bit |
Thank you so much for your guidance in every steps @nabobalis . |
Summary
This pull request resolves conflicts and merges the latest changes from the main branch into the feature-branch. The changes include:
set_attenuation_coefficients
directly into thefnrgf
function.fnrgf
function to acceptrange_mean
,range_std
, andcutoff
parameters.radial.py
andtest_radial.py
.Changes Made
fnrgf
function.test_radial.py
to reflect the changes.Testing
test_radial.py
have been updated and pass successfully.Related Issues
Checklist
Reviewers