Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(es/minifier): Remove one simplifier invocation #10200

Closed
wants to merge 3 commits into from
Closed

perf(es/minifier): Remove one simplifier invocation #10200

wants to merge 3 commits into from
+4 −15

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 15, 2025 •
edited
Loading

Description:

I'll fix all regressions before merging this PR. I want to check the difference of the output and the time of each component.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b2d2ab7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 Graphite App
Copy link
Member Author

kdy1 commented Mar 15, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 15, 2025
Closed
Merged
Merged
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from 4a6fe38 to d51d376 Compare March 15, 2025 04:47
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 15, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10200 will create unknown performance changes

Comparing kdy1/min-to-pure (b2d2ab7) with kdy1/move-logic (b0296d2)

Summary

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 deserialization of serde N/A 2.4 µs N/A
🆕 serialization of serde N/A 2.8 µs N/A

@kdy1 kdy1 self-assigned this Mar 15, 2025
@kdy1 kdy1 added this to the Planned milestone Mar 15, 2025
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from d51d376 to 390dbde Compare March 15, 2025 08:50
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 72c6a4c to 6da3fb2 Compare March 15, 2025 08:50
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch 2 times, most recently from 2be5110 to ebbc799 Compare March 17, 2025 03:15
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 10b3aaa to 805475a Compare March 17, 2025 03:48
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from 980e2f4 to 0dd5908 Compare March 17, 2025 03:48
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 805475a to 0038446 Compare March 17, 2025 03:50
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch 2 times, most recently from 6f9eac4 to d7d1efb Compare March 17, 2025 05:48
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 0038446 to fb5323f Compare March 17, 2025 05:48
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from d7d1efb to fd67efb Compare March 17, 2025 07:19
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from fb5323f to 50729ab Compare March 17, 2025 07:19
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from fd67efb to d6e8559 Compare March 17, 2025 08:14
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 50729ab to 7d8a1b1 Compare March 17, 2025 08:14
This was referenced Mar 17, 2025
Merged
Merged
Merged
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 7d8a1b1 to f01bce2 Compare March 17, 2025 08:26
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from d6e8559 to 9b532b1 Compare March 17, 2025 08:26
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from f01bce2 to 74d42ff Compare March 17, 2025 08:34
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from 9b532b1 to 38179ee Compare March 17, 2025 08:34
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 74d42ff to ee7a3e5 Compare March 17, 2025 09:12
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from 38179ee to 7cf41dd Compare March 17, 2025 09:13
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from ee7a3e5 to 325503a Compare March 17, 2025 09:39
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from 7cf41dd to 3002808 Compare March 17, 2025 09:39
@kdy1 kdy1 mentioned this pull request Mar 17, 2025
Closed
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 325503a to f71866f Compare March 17, 2025 09:46
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from 3002808 to fa617fa Compare March 17, 2025 09:46
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from f71866f to 6d850eb Compare March 17, 2025 10:15
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from fa617fa to 5bfc9de Compare March 17, 2025 10:16
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 6d850eb to 4fb327c Compare March 17, 2025 10:28
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch 2 times, most recently from 05eeadd to ca018a4 Compare March 17, 2025 13:41
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 4fb327c to 362e256 Compare March 17, 2025 13:41
@kdy1 kdy1 mentioned this pull request Mar 17, 2025
Closed
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from 362e256 to a3e1082 Compare March 17, 2025 14:00
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from ca018a4 to 6f397ff Compare March 17, 2025 14:00
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from a3e1082 to a81054f Compare March 17, 2025 17:16
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from 6f397ff to cc1e6f2 Compare March 17, 2025 17:16
@kdy1 kdy1 force-pushed the kdy1/move-logic branch from a81054f to b0296d2 Compare March 18, 2025 09:52
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch from cc1e6f2 to b2d2ab7 Compare March 18, 2025 09:52
@kdy1
Copy link
Member Author

kdy1 commented Mar 18, 2025

Closing as I'm going to merge this into #10202

@kdy1 kdy1 closed this Mar 18, 2025
@kdy1 kdy1 deleted the kdy1/min-to-pure branch March 18, 2025 18:40
@kdy1 kdy1 modified the milestones: Planned, v1.11.12 Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.11.12
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1