Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/minifier): Merge expr_simplifier into pure optimizer #10202

Merged
merged 80 commits into from
Mar 24, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 15, 2025

Description:

Merge the expression simplifier into the pure optimizer, for performance.

Copy link

changeset-bot bot commented Mar 15, 2025

🦋 Changeset detected

Latest commit: 87ff68e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

kdy1 commented Mar 15, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kdy1 kdy1 force-pushed the kdy1/expr-simplifier branch from 62ad012 to 0e5ffda Compare March 15, 2025 04:47
@kdy1 kdy1 self-assigned this Mar 15, 2025
@kdy1 kdy1 added this to the Planned milestone Mar 15, 2025
@kdy1 kdy1 force-pushed the kdy1/expr-simplifier branch from 0e5ffda to a9da450 Compare March 15, 2025 08:50
Copy link

codspeed-hq bot commented Mar 15, 2025

CodSpeed Performance Report

Merging #10202 will degrade performances by 1.75%

Comparing kdy1/expr-simplifier (86ae574) with main (589bcd7)

Summary

⚡ 13 improvements
❌ 1 regressions
✅ 138 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/lints/libs/d3 28.3 ms 28 ms +1.03%
es/lints/libs/terser 29.2 ms 29.7 ms -1.75%
es/minifier/libs/antd 2.6 s 2.6 s +2.4%
es/minifier/libs/d3 471.6 ms 459.1 ms +2.73%
es/minifier/libs/echarts 1.8 s 1.8 s +3.22%
es/minifier/libs/jquery 119.8 ms 117 ms +2.36%
es/minifier/libs/lodash 140.1 ms 137.8 ms +1.7%
es/minifier/libs/moment 76.7 ms 74.7 ms +2.59%
es/minifier/libs/react 24.1 ms 23.6 ms +2.16%
es/minifier/libs/terser 417.2 ms 405.3 ms +2.95%
es/minifier/libs/three 762 ms 738.5 ms +3.19%
es/minifier/libs/typescript 4.5 s 4.4 s +3.07%
es/minifier/libs/victory 1.1 s 1 s +3.02%
es/minifier/libs/vue 176.8 ms 173.2 ms +2.07%

@kdy1
Copy link
Member Author

kdy1 commented Mar 15, 2025

   Compiling swc_ecma_minifier v12.2.0 (/Users/kdy1/projects/s/minifier/crates/swc_ecma_minifier)
    Finished `bench` profile [optimized + debuginfo] target(s) in 1m 23s
     Running benches/full.rs (/Users/kdy1/projects/s/minifier/target/release/deps/full-3f5c87adc506d8c8)
Gnuplot not found, using plotters backend
HEAD의 현재 위치는 a967ebb formbricks
Benchmarking es/minifier/real/es/minifier/real/sequential: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 100.7s.
es/minifier/real/es/minifier/real/sequential
                        time:   [10.063 s 10.083 s 10.112 s]
                        change: [-7.8265% -6.4633% -5.4376%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe
Benchmarking es/minifier/real/es/minifier/real/parallel: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 25.1s.
es/minifier/real/es/minifier/real/parallel
                        time:   [2.1879 s 2.3295 s 2.5375 s]
                        change: [-18.263% -9.2977% -0.0270%] (p = 0.09 > 0.05)
                        No change in performance detected.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high severe

@kdy1 kdy1 force-pushed the kdy1/expr-simplifier branch from a9da450 to 88ec228 Compare March 17, 2025 02:41
@kdy1 kdy1 force-pushed the kdy1/dead-code branch 2 times, most recently from 193efca to f53f9f0 Compare March 17, 2025 03:15
@kdy1 kdy1 force-pushed the kdy1/expr-simplifier branch 2 times, most recently from 3748f32 to fae795c Compare March 17, 2025 03:40
@kdy1 kdy1 changed the base branch from kdy1/dead-code to graphite-base/10202 March 17, 2025 03:47
@kdy1 kdy1 force-pushed the kdy1/expr-simplifier branch from fae795c to 12c7a25 Compare March 17, 2025 03:48
@kdy1 kdy1 force-pushed the graphite-base/10202 branch from e5ca81e to 0dd5908 Compare March 17, 2025 03:48
@kdy1 kdy1 changed the base branch from graphite-base/10202 to kdy1/min-to-pure March 17, 2025 03:48
@kdy1 kdy1 force-pushed the kdy1/expr-simplifier branch from 12c7a25 to 90b7d9c Compare March 17, 2025 03:50
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch 2 times, most recently from 6f9eac4 to d7d1efb Compare March 17, 2025 05:48
@kdy1 kdy1 force-pushed the kdy1/expr-simplifier branch 2 times, most recently from 5371688 to dd8def5 Compare March 17, 2025 07:19
@kdy1 kdy1 force-pushed the kdy1/min-to-pure branch 2 times, most recently from fd67efb to d6e8559 Compare March 17, 2025 08:14
@kdy1 kdy1 marked this pull request as ready for review March 24, 2025 01:16
@kdy1 kdy1 requested review from a team as code owners March 24, 2025 01:16
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 24, 2025
@kdy1 kdy1 enabled auto-merge (squash) March 24, 2025 01:17
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 24, 2025
@kdy1 kdy1 disabled auto-merge March 24, 2025 02:55
@kdy1 kdy1 merged commit 9c9b0ba into main Mar 24, 2025
167 of 168 checks passed
@kdy1 kdy1 deleted the kdy1/expr-simplifier branch March 24, 2025 02:55
@kdy1 kdy1 modified the milestones: Planned, v1.11.13 Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant