-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new theme system #161
Conversation
Thanks a lot for this excellent file manager! I use it on a daily basis. I have played a bit with the current theming options and would like to suggest options to style
Maybe this can be (or already is?) considered in your new theme system. Thank you very much! |
Thanks for the suggestions; this is something I've been planning to do all along, but it might not be included in this big PR but rather in the smaller one that follows, as part of a progressive enhancement. |
Excellent. Not only is your file manager of top quality, but also very well maintained! Thanks a lot for this. |
d6541a9
to
784a1c6
Compare
2b93ed0
to
167b44b
Compare
I just wanted to repeat this! ❤ |
Not sure it it's ready for testing, but I just tried this branch, and got a crash:
I was browsing my nix store, which is huge. I also noticed it was much slower than other versions of yazi, at least in this huge dir. |
Hey @magnetophon, I've pushed a new optimized version, and it should work. Thanks for your interest in this ongoing feature. |
Now it's blazing fast again, with no crashes. |
19f3e1f
to
14c194c
Compare
@Brixy Hi, this PR is completed. I have some time to work on it next. Would you like to file an issue for that? |
Yazi now supports rewriting most of the UI using Lua and fully utilizes existing layout components.
You only need to import it as a plugin in
yazi.toml
:and rewrite the parts you want, such as:
Then we have:
The new theme system documentation is currently in progress. For now, you can refer to the preset components at https://github.com/sxyazi/yazi/tree/main/plugin/preset/components
TODOs:
Features:
Issues:
The PR is bigger than anticipated and has taken more time.
There are still some unfinished works, additional PRs will be implemented shortly to prevent this one from continuing to expand.