Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: collect and fix all hard coded themes and color #221

Merged
merged 12 commits into from
Oct 12, 2023
Merged

fix: collect and fix all hard coded themes and color #221

merged 12 commits into from
Oct 12, 2023

Conversation

Eric-Song-Nop
Copy link
Contributor

@Eric-Song-Nop Eric-Song-Nop commented Sep 26, 2023 •
edited
Loading

  • Which
  • Tasks
  • A color in manager/folder (not sure what is that)
  • help
  • find arrow
  • header
  • input
  • select

Plz let me know if there is more.
#149 #161

@sxyazi
Copy link
Owner

sxyazi commented Sep 27, 2023

Excellent work!

@sxyazi sxyazi mentioned this pull request Sep 27, 2023
Merged
8 tasks
@Eric-Song-Nop
Copy link
Contributor Author

still need to fix ansi color problem

@Eric-Song-Nop Eric-Song-Nop marked this pull request as ready for review September 27, 2023 11:44
@Eric-Song-Nop Eric-Song-Nop changed the base branch from main to pr-9712724b September 27, 2023 11:45
@Eric-Song-Nop Eric-Song-Nop changed the base branch from pr-9712724b to main September 28, 2023 15:02
@Eric-Song-Nop
Copy link
Contributor Author

Fix ansi

@sxyazi
Copy link
Owner

sxyazi commented Oct 3, 2023

Sorry for taking so long to address this PR.

I will merge it once #161 is completed, since pr-161 breaks some things, such as removing the .get() method from THEME.xxx.get(). It shouldn't be too far off. 🚀

@sxyazi sxyazi mentioned this pull request Oct 9, 2023
Open
59 tasks
@sxyazi sxyazi merged commit d032b68 into sxyazi:main Oct 12, 2023
3 checks passed
This was referenced Oct 12, 2023
Closed
Merged
@branchvincent branchvincent mentioned this pull request Oct 21, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eric-Song-Nop @sxyazi