Adjust Github Actions #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=========================================
Coverage 37.99% 37.99%
Complexity 1115 1115
=========================================
Files 181 181
Lines 4427 4427
=========================================
Hits 1682 1682
Misses 2745 2745 ☔ View full report in Codecov by Sentry. |
0x46616c6b
force-pushed
the
Adjust-Github-Actions
branch
2 times, most recently
from
265c432 to
502a724
Compare
0x46616c6b
force-pushed
the
Adjust-Github-Actions
branch
from
502a724 to
29be8d7
Compare
doobry-systemli
approved these changes
Dec 30, 2023
| @@ -30,15 +28,18 @@ env: | |||
|
|
|||
| jobs: | |||
| unit-tests: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
What's the reason for this change? As long as there's no incompatibilities with ubuntu-latest I'd prefer to keep it to not have to manually bump it later. But no hard feelings here 🤷
There was a problem hiding this comment.
I prefer following the principle of having fixed versions instead of floating ones. This way, I aim to avoid any surprises in the future. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
permissionsin workflows (should be the default)ubuntu-22.04