Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Github Actions #532

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Adjust Github Actions #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 33 additions & 17 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ on:
branches:
- main

permissions: read-all

env:
DATABASE_DRIVER: pdo_sqlite
DATABASE_URL: sqlite:///%kernel.project_dir%/var/db_test.sqlite
Expand All @@ -30,15 +28,18 @@ env:

jobs:
unit-tests:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this change? As long as there's no incompatibilities with ubuntu-latest I'd prefer to keep it to not have to manually bump it later. But no hard feelings here 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer following the principle of having fixed versions instead of floating ones. This way, I aim to avoid any surprises in the future. 😄

name: PHPUnit
strategy:
fail-fast: false
matrix:
php-versions: ['7.4', '8.2']
steps:
- uses: actions/checkout@v4
- uses: shivammathur/setup-php@v2
- name: Checkout
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
extensions: openssl, sodium
Expand Down Expand Up @@ -76,16 +77,21 @@ jobs:
matrix:
php-versions: ['7.4', '8.2']
steps:
- uses: actions/checkout@v4
- uses: shivammathur/setup-php@v2
- name: Checkout
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
extensions: openssl, sodium
tools: composer

- uses: actions/setup-node@v4
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: 'lts/*'
cache: 'yarn'

- name: Get composer cache directory
id: composer-cache
Expand Down Expand Up @@ -124,16 +130,21 @@ jobs:
--health-timeout 5s
--health-retries 5
steps:
- uses: actions/checkout@v4
- uses: shivammathur/setup-php@v2
- name: Checkout
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '7.4'
extensions: openssl, sodium, mysql
tools: composer

- uses: actions/setup-node@v4
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: 'lts/*'
cache: 'yarn'

- name: Get composer cache directory
id: composer-cache
Expand Down Expand Up @@ -171,16 +182,21 @@ jobs:
--health-timeout 5s
--health-retries 5
steps:
- uses: actions/checkout@v4
- uses: shivammathur/setup-php@v2
- name: Checkout
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.2'
extensions: openssl, sodium, pgsql
tools: composer

- uses: actions/setup-node@v4
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: '16'
node-version: 'lts/*'
cache: 'yarn'

- name: Get composer cache directory
id: composer-cache
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/psalm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,20 @@ name: Psalm Static analysis

on: [pull_request]

permissions: read-all

jobs:
psalm:
name: Psalm
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Checkout code
- name: Checkout
uses: actions/checkout@v4

- name: Psalm
uses: docker://vimeo/psalm-github-actions
with:
security_analysis: true
report_file: results.sarif

- name: Upload Security Analysis results to GitHub
uses: github/codeql-action/upload-sarif@v3
with:
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/security-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ on:
schedule:
- cron: '0 8 * * 1'

permissions: read-all

jobs:
security-check:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
name: PHP Security Checker
steps:
- uses: actions/checkout@v4
- uses: symfonycorp/security-checker-action@v5
- name: Checkout
uses: actions/checkout@v4

- name: Symfony Security Check
uses: symfonycorp/security-checker-action@v5
Loading