Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spinner should resize correctly #207

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: spinner should resize correctly #207

merged 1 commit into from
Sep 21, 2023

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Sep 20, 2023

See video for the issue and why this fixes it when setting --spinner-size: 48px;

CleanShot.2023-09-20.at.19.00.40.mp4
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.207.6256628576.0
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.207.6256628576.0
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for tablekit ready!

Name Link
🔨 Latest commit a8f022e
🔍 Latest deploy log https://app.netlify.com/sites/tablekit/deploys/650bb17358369d0009b4e743
😎 Deploy Preview https://deploy-preview-207--tablekit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimeonC SimeonC added the patch Increment the patch version when merged label Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit a8f022e. ± Comparison against base commit 59b6fb3.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC enabled auto-merge (rebase) September 21, 2023 03:50
@SimeonC SimeonC merged commit defb885 into next Sep 21, 2023
@SimeonC SimeonC deleted the fix-spinner-sizing branch September 21, 2023 06:34
@github-actions github-actions bot added the prerelease This change is available in a prerelease. label Sep 21, 2023
@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged prerelease This change is available in a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants