Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tablekit-react-select): allow maxMenuHeight to work #209

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix(tablekit-react-select): allow maxMenuHeight to work #209

merged 1 commit into from
Oct 12, 2023

Conversation

k-baldauf
Copy link
Contributor

@k-baldauf k-baldauf commented Oct 11, 2023 •
edited by github-actions bot
Loading

Due to how our CSS works when using react-select, we have a styling that gets applied with priority over the max-height set by maxMenuHeight. This PR sticks !important on that CSS so it wins out.

A use case with maxMenuHeight prop set to 600:

Before:
CSS rules showing 300px overriding 600px
After:
CSS rules showing the 600px having priority over 300px

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.209.6479917599.0
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.209.6479917599.0
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]

@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for tablekit ready!

Name Link
🔨 Latest commit 406ea1d
🔍 Latest deploy log https://app.netlify.com/sites/tablekit/deploys/65265be6209a0300084b2d97
😎 Deploy Preview https://deploy-preview-209--tablekit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 406ea1d. ± Comparison against base commit defb885.

♻️ This comment has been updated with latest results.

@k-baldauf k-baldauf added the patch Increment the patch version when merged label Oct 11, 2023
@k-baldauf k-baldauf force-pushed the react-select-maxmenuheight branch from 35a2075 to 406ea1d Compare October 11, 2023 08:25
@SimeonC SimeonC merged commit e7ea0ec into next Oct 12, 2023
11 checks passed
@SimeonC SimeonC deleted the react-select-maxmenuheight branch October 12, 2023 04:22
@github-actions
Copy link

🚀 PR was released in @tablecheck/[email protected] 🚀

@github-actions github-actions bot added the prerelease This change is available in a prerelease. label Oct 12, 2023
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkgardose nkgardose nkgardose approved these changes

@SimeonC SimeonC SimeonC approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged prerelease This change is available in a prerelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-baldauf @SimeonC @nkgardose