Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-alert): handle case when no icon #217

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix(input-alert): handle case when no icon #217

merged 1 commit into from
Mar 15, 2024

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Mar 11, 2024

The "Bare" and "Disabled" input-alert types have no icons associated, in this case we should handle a "Single Element"

const inputAlertIconMap: Record<
inputAlert.Props['data-variant'],
JSX.Element | null
> = {
info: <Information size={16} />,
error: <WarningAltFilled size={16} />,
warning: <WarningAlt size={16} />,
bare: null,
disabled: null
};

Current NEXT branch

CleanShot 2024-03-11 at 11 54 35

This Fix

CleanShot 2024-03-11 at 11 56 14

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.217.8258750336.0
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.217.8258750336.0
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for tablekit ready!

Name Link
🔨 Latest commit 8a4b6ed
🔍 Latest deploy log https://app.netlify.com/sites/tablekit/deploys/65f11426c6d0e100083d9d5c
😎 Deploy Preview https://deploy-preview-217--tablekit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SimeonC SimeonC added the patch Increment the patch version when merged label Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 8a4b6ed. ± Comparison against base commit a13a4a5.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC force-pushed the fix-input-alert branch 3 times, most recently from f38db4f to 6865942 Compare March 13, 2024 02:25
Other misc tweaks to match with figma designs.
Added support for upcoming `field-sizing` property that design team wants by default
@SimeonC SimeonC merged commit a8dd77a into next Mar 15, 2024
15 checks passed
@SimeonC SimeonC deleted the fix-input-alert branch March 15, 2024 01:46
@github-actions github-actions bot added the prerelease This change is available in a prerelease. label Mar 15, 2024
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged prerelease This change is available in a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants