Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use disabled text color in input and select #220

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: use disabled text color in input and select #220

merged 1 commit into from
Apr 25, 2024

Conversation

SashaShostyr
Copy link
Contributor

@SashaShostyr SashaShostyr commented Apr 22, 2024 •
edited by github-actions bot
Loading

Apply correct text color for input and select when element is disabled.

Issues:
image
image

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.220.8793955100.0
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.220.8793955100.0
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]

@SashaShostyr SashaShostyr requested a review from SimeonC April 22, 2024 10:24
@netlify Netlify
Copy link

netlify bot commented Apr 22, 2024 •
edited
Loading

✅ Deploy Preview for tablekit ready!

Name Link
🔨 Latest commit 9f9b599
🔍 Latest deploy log https://app.netlify.com/sites/tablekit/deploys/66271d917fc3730008dc4cfd
😎 Deploy Preview https://deploy-preview-220--tablekit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited
Loading

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 9f9b599. ± Comparison against base commit 49d5858.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC added the patch Increment the patch version when merged label Apr 23, 2024
@SimeonC
Copy link
Contributor

SimeonC commented Apr 23, 2024

Looks like we got some audit issues 🤔
I'll try get a separate PR up to fix the audit then we can rebase this one

@SashaShostyr @SimeonC
fix: use disabled text color in input and select
9f9b599 
Apply correct text color for input and select when element is disabled.
@SimeonC SimeonC force-pushed the fix-disabled-text-color-input-and-select branch from b487273 to 9f9b599 Compare April 23, 2024 02:31
@SimeonC SimeonC enabled auto-merge (rebase) April 25, 2024 04:07
@SimeonC SimeonC merged commit e6cf4f8 into next Apr 25, 2024
14 of 15 checks passed
@SimeonC SimeonC deleted the fix-disabled-text-color-input-and-select branch April 25, 2024 06:19
@github-actions GitHub Actions
Copy link

🚀 PR was released in @tablecheck/[email protected], @tablecheck/[email protected], @tablecheck/[email protected], @tablecheck/[email protected], @tablecheck/[email protected], @tablecheck/[email protected], @tablecheck/[email protected] 🚀

@github-actions github-actions bot added the prerelease This change is available in a prerelease. label Apr 25, 2024
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anarakhlina anarakhlina anarakhlina approved these changes

@SimeonC SimeonC SimeonC approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged prerelease This change is available in a prerelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SashaShostyr @SimeonC @anarakhlina