-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat periodic session checks #2032
Draft
bjoern-m
wants to merge
7
commits into
main
Choose a base branch
from
feat-periodic-session-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip chore: resolve import cycle
@@ -25,6 +24,8 @@ import { SessionClient } from "./lib/client/SessionClient"; | |||
* if email delivery by Hanko is enabled. If email delivery by Hanko is disabled and the | |||
* relying party configures a webhook for the "email.send" event, then the set language is | |||
* reflected in the payload of the token contained in the webhook request. | |||
* @property {number=} sessionCheckInterval - Interval for session validity checks in milliseconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @property {Pick<Email, "address" | "is_primary" | "is_verified">} [email] - Email information associated with the subject (optional). | ||
* @property {string} session_id - The session identifier linked to the claims. | ||
*/ | ||
export interface Claims { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Claims now also contain a username (introduced in #2036), should we also add this here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes an overhaul of session management within the SDK.
Implementation
Scheduler
to support periodic and timeout-based session validation.SessionChannel
class to facilitate inter-tab communication for session-related events, including expiration, creation, and leadership requests for session validation.WindowActivityManager
to monitor window focus, blur, and visibility changes.jwt
field is no longer included in thesession-created-event
.expirationSeconds
field has been deprecated.claims
are now passed through thesession-created-event
and shared across all browser windows or tabs.is_valid()
Functionhanko.session.is_valid()
function is now deprecated.await hanko.sessionClient.validate()
by requesting the API to check the session but blocks the browser threads.hanko.sessionClient.validate()
instead.