-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat periodic session checks #2032
Draft
bjoern-m
wants to merge
7
commits into
main
Choose a base branch
from
feat-periodic-session-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cf4d305
feat: enhance session response
bjoern-m 4939b59
feat: always persist sessions server-side, config adjustments
bjoern-m 0180702
chore: adjust tests
bjoern-m 6426eb4
chore: rename test helper file
bjoern-m edfdad9
feat: periodic session checks and inter-tab communication
bjoern-m 25f37eb
chore: remove deprecated tests
bjoern-m 444f8f7
chore: fix tests
bjoern-m File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -244,7 +244,45 @@ export interface Identity { | |
provider: string; | ||
} | ||
|
||
/** | ||
* Represents the claims associated with a session or token. | ||
* | ||
* @interface | ||
* @category SDK | ||
* @subcategory DTO | ||
* @property {string} subject - The subject or identifier of the claims. | ||
* @property {string} [issued_at] - The timestamp when the claims were issued (optional). | ||
* @property {string} expiration - The timestamp when the claims expire. | ||
* @property {string[]} [audience] - The intended audience(s) for the claims (optional). | ||
* @property {string} [issuer] - The entity that issued the claims (optional). | ||
* @property {Pick<Email, "address" | "is_primary" | "is_verified">} [email] - Email information associated with the subject (optional). | ||
* @property {string} session_id - The session identifier linked to the claims. | ||
*/ | ||
export interface Claims { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Claims now also contain a username (introduced in #2036), should we also add this here? |
||
subject: string; | ||
issued_at?: string; | ||
expiration: string; | ||
audience?: string[]; | ||
issuer?: string; | ||
email?: Pick<Email, "address" | "is_primary" | "is_verified">; | ||
session_id: string; | ||
} | ||
|
||
/** | ||
* Represents the response from a session validation or retrieval operation. | ||
* | ||
* @interface | ||
* @category SDK | ||
* @subcategory DTO | ||
* @property {boolean} is_valid - Indicates whether the session is valid. | ||
* @property {Claims} [claims] - The claims associated with the session (optional). | ||
* @property {string} [expiration_time] - The expiration timestamp of the session (optional). | ||
* @property {string} [user_id] - The user ID linked to the session (optional). | ||
*/ | ||
export interface SessionCheckResponse { | ||
is_valid: boolean; | ||
claims?: Claims; | ||
expiration_time?: string; | ||
user_id?: string; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme also mentions the following: "Must be greater than 3000 (3s)." I think this info would be useful here too.
Also: it looks like it defaults to 30000 if I provide a value under 3000, so no error or the like. Maybe also mention this? Ignore this bulletpoint if I misinterpreted this.