Skip to content

Refactor OG RPC - Superseded #8438

Refactor OG RPC - Superseded

Refactor OG RPC - Superseded #8438

Triggered via pull request March 8, 2024 18:26
Status Failure
Total duration 49s
Artifacts

golangci-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 12 warnings
lint: tools/walletextension/rpcapi/utils.go#L42
cognitive complexity 33 of func `ExecAuthRPC` is high (> 30) (gocognit)
lint: go/common/gethencoding/geth_encoding.go#L173
`if ok` has complex nested blocks (complexity: 8) (nestif)
lint: tools/walletextension/rpcapi/transaction_api.go#L95
`if s.we.Config.StoreIncomingTxs` has complex nested blocks (complexity: 6) (nestif)
lint: tools/walletextension/rpcapi/filter_api.go#L95
searchForAddressInFilterCriteria - result 1 (error) is always nil (unparam)
lint: tools/walletextension/rpcapi/blockchain_api.go#L80
type `proofList` is unused (unused)
lint: tools/walletextension/rpcapi/blockchain_api.go#L196
field `we` is unused (unused)
lint: tools/walletextension/httpapi/user_conn.go#L16
var `upgrader` is unused (unused)
lint: tools/walletextension/httpapi/user_conn.go#L36
type `userConnWS` is unused (unused)
lint: tools/walletextension/httpapi/user_conn.go#L80
func `(*userConnWS).ReadRequest` is unused (unused)
lint: tools/walletextension/httpapi/user_conn.go#L91
func `(*userConnWS).WriteResponse` is unused (unused)
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4, actions/checkout@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint
Restore cache failed: Dependencies file is not found in /home/runner/work/go-ten/go-ten. Supported file pattern: go.sum
lint: tools/walletextension/rpcapi/blockchain_api.go#L24
var-naming: method ChainId should be ChainID (revive)
lint: tools/walletextension/rpcapi/blockchain_api.go#L27
var-naming: var chainId should be chainID (revive)
lint: tools/walletextension/rpcapi/blockchain_api.go#L171
var-naming: var userId should be userID (revive)
lint: tools/walletextension/rpcapi/gw_user.go#L20
var-naming: struct field userId should be userID (revive)
lint: tools/walletextension/rpcapi/gw_user.go#L33
var-naming: func parameter userId should be userID (revive)
lint: tools/walletextension/rpcapi/utils.go#L44
var-naming: var userId should be userID (revive)
lint: tools/walletextension/rpcapi/ethereum_api.go#L37
unexported-return: exported method FeeHistory returns unexported type *rpcapi.feeHistoryResult, which can be annoying to use (revive)
lint: tools/walletextension/rpcapi/debug_api.go#L19
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
lint: tools/walletextension/rpcapi/transaction_api.go#L46
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
lint: tools/walletextension/rpcapi/blockchain_api.go#L270
unexported-return: exported method CreateAccessList returns unexported type *rpcapi.accessListResult, which can be annoying to use (revive)