Downgrade spammy log messages #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request primarily focuses on enhancing logging for better tracking and debugging, and updating a network configuration for a test case. The changes involve adding a debug log message in the batch production process, refining a log message and comment in the Changes
TipsChat with CodeRabbit Bot (
|
otherview
reviewed
Oct 17, 2023
| @@ -21,7 +21,7 @@ func TestNetworkAvailability(t *testing.T) { | |||
| networktest.Run( | |||
| "network-availability", | |||
| t, | |||
| env.DevTestnet(), | |||
| env.SepoliaTestnet(), | |||
There was a problem hiding this comment.
We also want to change this ?
There was a problem hiding this comment.
haha oops, thanks
otherview
approved these changes
Oct 17, 2023
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (3)
- go/enclave/nodetype/sequencer.go (1 hunks)
- go/host/enclave/guardian.go (1 hunks)
- integration/networktest/tests/helpful/availability_test.go (1 hunks)
Files skipped from review due to trivial changes (2)
- go/enclave/nodetype/sequencer.go
- go/host/enclave/guardian.go
Additional comments (Suppressed): 1
integration/networktest/tests/helpful/availability_test.go (1)
- 24-24: The network configuration for the test has been changed from
env.DevTestnet()toenv.SepoliaTestnet(). Ensure that the Sepolia testnet is available and properly configured for this test. Also, verify that this change doesn't affect other tests or parts of the system that rely on the results of this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
To reduce our datadog log volume these non-critical messages can be downgraded to debug.
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks