Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade spammy log messages #1609

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Downgrade spammy log messages #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10cf4e0
downgrade spammy logs
BedrockSquirrel Oct 17, 2023
7086286
revert miscommit
BedrockSquirrel Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion go/enclave/nodetype/sequencer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ func (s *sequencer) createNewHeadBatch(l1HeadBlock *common.L1Block, skipBatchIfE
if _, err := s.produceBatch(sequencerNo.Add(sequencerNo, big.NewInt(1)), l1HeadBlock.Hash(), headBatch.Hash(), transactions, uint64(time.Now().Unix()), skipBatchIfEmpty); err != nil {
if errors.Is(err, components.ErrNoTransactionsToProcess) {
// skip batch production when there are no transactions to process
s.logger.Info("Skipping batch production, no transactions to execute")
// todo: this might be a useful event to track for metrics (skipping batch production because empty batch)
s.logger.Debug("Skipping batch production, no transactions to execute")
return nil
}
return fmt.Errorf(" failed producing batch. Cause: %w", err)
Expand Down
4 changes: 2 additions & 2 deletions go/host/enclave/guardian.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,8 @@ func (g *Guardian) catchupWithL2() error {
func (g *Guardian) submitL1Block(block *common.L1Block, isLatest bool) (bool, error) {
g.logger.Trace("submitting L1 block", log.BlockHashKey, block.Hash(), log.BlockHeightKey, block.Number())
if !g.submitDataLock.TryLock() {
g.logger.Info("Unable to submit block, already submitting another block")
// we are already submitting a block, and we don't want to leak goroutines, we wil catch up with the block later
g.logger.Debug("Unable to submit block, enclave is busy processing data")
// we are waiting for the enclave to process other data, and we don't want to leak goroutines, we wil catch up with the block later
return false, nil
}
receipts, err := g.sl.L1Repo().FetchObscuroReceipts(block)
Expand Down
Loading