Return error instead of just logging it if client fails #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes primarily focus on enhancing error handling in the Changes
TipsChat with CodeRabbit Bot (
|
otherview
approved these changes
Nov 1, 2023
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- tools/walletextension/accountmanager/account_manager.go (1 hunks)
- tools/walletextension/wallet_extension.go (1 hunks)
Files skipped from review due to trivial changes (1)
- tools/walletextension/accountmanager/account_manager.go
Comment on lines
249
to
253
| encClient, err := common.CreateEncClient(w.hostAddr, addressFromMessage.Bytes(), privateKeyBytes, signature, w.Logger()) | ||
| if err != nil { | ||
| w.Logger().Error(fmt.Errorf("error creating encrypted client for user: (%s), %w", hexUserID, err).Error()) | ||
| return errors.New(fmt.Errorf("error creating encrypted client for user: (%s), %w", hexUserID, err).Error()) | ||
| } |
There was a problem hiding this comment.
The error message is being wrapped twice, which is unnecessary. The error returned from common.CreateEncClient should be returned directly after logging it.
- w.Logger().Error(fmt.Errorf("error creating encrypted client for user: (%s), %w", hexUserID, err).Error())
- return errors.New(fmt.Errorf("error creating encrypted client for user: (%s), %w", hexUserID, err).Error())
+ w.Logger().Error(fmt.Sprintf("error creating encrypted client for user: (%s), %v", hexUserID, err))
+ return errCommitable suggestion (Beta)
Suggested change
| encClient, err := common.CreateEncClient(w.hostAddr, addressFromMessage.Bytes(), privateKeyBytes, signature, w.Logger()) | |
| if err != nil { | |
| w.Logger().Error(fmt.Errorf("error creating encrypted client for user: (%s), %w", hexUserID, err).Error()) | |
| return errors.New(fmt.Errorf("error creating encrypted client for user: (%s), %w", hexUserID, err).Error()) | |
| } | |
| encClient, err := common.CreateEncClient(w.hostAddr, addressFromMessage.Bytes(), privateKeyBytes, signature, w.Logger()) | |
| if err != nil { | |
| w.Logger().Error(fmt.Sprintf("error creating encrypted client for user: (%s), %v", hexUserID, err)) | |
| return err | |
| } |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- tools/walletextension/accountmanager/account_manager.go (1 hunks)
- tools/walletextension/wallet_extension.go (1 hunks)
Files skipped from review due to trivial changes (1)
- tools/walletextension/accountmanager/account_manager.go
Additional comments: 1
tools/walletextension/wallet_extension.go (1)
- 249-255: The error handling and logging are correctly implemented. The function now returns an error if there's an issue creating an encrypted client, allowing the caller to handle the error appropriately. This is a good practice for error management and system reliability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Please provide a description and a link to the underlying ticket
What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks