Add new GetRollupData API to enclave client #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-malene
requested changes
Feb 27, 2024
go/common/enclave.go
Outdated
| GetBatchBySeqNo(seqNo uint64) (*ExtBatch, SystemError) | ||
|
|
||
| // GetRollupData - retrieve the first batch sequence and start time for a given rollup. | ||
| GetRollupData(internalRollup []byte) (*big.Int, *uint64, SystemError) |
There was a problem hiding this comment.
I think it's better we return a "PublicRollupMetadata" struct (and a SystemError)
go/enclave/enclave.go
Outdated
| @@ -295,6 +296,15 @@ func (e *enclaveImpl) GetBatchBySeqNo(seqNo uint64) (*common.ExtBatch, common.Sy | |||
| return b, nil | |||
| } | |||
|
|
|||
| func (e *enclaveImpl) GetRollupData(internalRollup []byte) (*big.Int, *uint64, common.SystemError) { | |||
| calldataRollupHeader := new(common.CalldataRollupHeader) | |||
There was a problem hiding this comment.
this is perfect stuff to retrieve from the database.
They should already be written in the "rollup" table.
It's a matter of selecting them from there
…llh/enclave-api-get-batch-start-seq
…b.com/ten-protocol/go-ten into willh/enclave-api-get-batch-start-seq
tudor-malene
requested changes
Feb 28, 2024
| @@ -162,6 +162,24 @@ type CalldataRollupHeader struct { | |||
| ReOrgs [][]byte `rlp:"optional"` // sparse list of reorged headers - non null only for reorgs. | |||
| } | |||
|
|
|||
| // PublicRollupMetadata contains internal rollup data that can be requested from the enclave. | |||
| type PublicRollupMetadata struct { | |||
There was a problem hiding this comment.
this is one way to marshal the metadata object.
The other way (which is what we've mostly done) is to use the "converters" in the grpc classes).
You can have a look at CrossChainMsg , as an example
tudor-malene
approved these changes
Feb 28, 2024
| @@ -76,10 +76,6 @@ func updateCanonicalValue(dbtx DBTransaction, isCanonical bool, values []common. | |||
| dbtx.ExecuteSQL(updateBatches, args...) | |||
| } | |||
|
|
|||
| func FetchBlockHeader(db *sql.DB, hash common.L1BlockHash) (*types.Header, error) { | |||
There was a problem hiding this comment.
where has this gone?
There was a problem hiding this comment.
It was unused so just got rid of it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
We need to be able to retrieve some of the internal rollup data from the enclave when storing data in the host DB.
What changes were made as part of this PR
CalldataRollupHeaderbyte slice as an argument and returns theCalldataRollupHeader.FirstBatchSequenceandCalldataRollupHeader.StartTimeTesting
Can't see a simple way to unit test this so I just manually called the function
processL1BlockTransactionsand ran the full network simulation test and verified the data through console logs.PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks