Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GetRollupData API to enclave client #1815

Merged
merged 15 commits into from
Feb 28, 2024
Merged

Add new GetRollupData API to enclave client #1815

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a4091dd
Add new GetRollupData API to enclave client
badgersrus Feb 26, 2024
0bef0af
Add missing files
badgersrus Feb 26, 2024
c1c4673
Add method to RPC server
badgersrus Feb 27, 2024
c2be5ee
gofumpt?
badgersrus Feb 27, 2024
1608e8b
simplify logic
badgersrus Feb 27, 2024
54e0a88
simplify logic
badgersrus Feb 27, 2024
17709ec
gofumpt
badgersrus Feb 27, 2024
6f55074
Remove whitespace
badgersrus Feb 27, 2024
da3be6e
Merge branch 'main' of https://github.com/ten-protocol/go-ten into wi…
badgersrus Feb 28, 2024
971e954
switch to PublicRollupMetadata and regen grpc interfaces
badgersrus Feb 28, 2024
4915690
Merge branch 'willh/enclave-api-get-batch-start-seq' of https://githu…
badgersrus Feb 28, 2024
94af724
add timestamp to rollup table and allow lookup of rollup metadata by …
badgersrus Feb 28, 2024
51ef861
remove logging
badgersrus Feb 28, 2024
993611c
use grpc msg to marshal rollup data strucs
badgersrus Feb 28, 2024
a4e9557
remove random gofumpt updates
badgersrus Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion go/common/enclave.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,12 @@ type Enclave interface {
// GetBatch - retrieve a batch if existing within the enclave db.
GetBatch(hash L2BatchHash) (*ExtBatch, SystemError)

// GetBatchBySeqNo - retrieve batch by sequencer number if it's in the db
// GetBatchBySeqNo - retrieve batch by sequencer number if it's in the db.
GetBatchBySeqNo(seqNo uint64) (*ExtBatch, SystemError)

// GetRollupData - retrieve the first batch sequence and start time for a given rollup.
GetRollupData(internalRollup []byte) (*big.Int, *uint64, SystemError)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better we return a "PublicRollupMetadata" struct (and a SystemError)


// CreateBatch - creates a new head batch extending the previous one for the latest known L1 head if the node is
// a sequencer. Will panic otherwise.
CreateBatch(skipIfEmpty bool) SystemError
Expand Down
Loading
Loading