Fix handling of metadata when using OAS 3.1 #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfranzel
reviewed
Jan 3, 2024
| @@ -3266,7 +3266,7 @@ def view_func(request, format=None): | |||
| @mock.patch('drf_spectacular.settings.spectacular_settings.OAS_VERSION', '3.1.0') | |||
| def test_basic_oas_3_1_nullable_cases(no_warnings, django_transforms): | |||
| class M14(models.Model): | |||
| field_json = models.JSONField(null=True) # case 1 | |||
| field_json = models.JSONField(null=True, help_text="field_json desc") # case 1 | |||
There was a problem hiding this comment.
would you mind adding a new field instead of changing the existing one. we'll get more coverage that way.
There was a problem hiding this comment.
Thanks for fixing it, hadn't had time to do it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 71 71
Lines 8698 8698
=======================================
Hits 8579 8579
Misses 119 119 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1133, still failing if there's some metadata set.
I don't know much about the internals of
drf-spectacular, let me know if anything needs to be changed.